take sched_debug.c out of nasal demon territory
PATCH 1/1 take sched_debug.c out of nasal demon territory
C99 6.10.3[11]: preprocessing directive within the argument list
of macro invocation => undefined behaviour. Don't do that...
---
kernel/sched_debug.c +6 -6
@@ -36,24 +36,24 @@ print_task(struct seq_file *m, struct rq *rq, struct task_struct *p, u64 now)else SEQ_printf (m," " ); -SEQ_printf (m,"%15s %5d %15Ld %13Ld %13Ld %9Ld %5d " -"%15Ld %15Ld %15Ld %15Ld %15Ld\n" , +SEQ_printf (m,"%15s %5d %15Ld %13Ld %13Ld %9Ld %5d " , p->comm, p->pid, (long long )p->se.fair_key, (long long )(p->se.fair_key - rq->cfs.fair_clock), (long long )p->se.wait_runtime, (long long )(p->nvcsw + p->nivcsw), - p->prio, + p->prio);#ifdef CONFIG_SCHEDSTATS +SEQ_printf (m,"%15Ld %15Ld %15Ld %15Ld %15Ld\n" , (long long )p->se.sum_exec_runtime, (long long )p->se.sum_wait_runtime, (long long )p->se.sum_sleep_runtime, (long long )p->se.wait_runtime_overruns, - (long long )p->se.wait_runtime_underruns + (long long )p->se.wait_runtime_underruns);#else - 0LL, 0LL, 0LL, 0LL, 0LL +SEQ_printf (m,"%15Ld %15Ld %15Ld %15Ld %15Ld\n" , +0LL ,0LL ,0LL ,0LL ,0LL );#endif - ); }static void print_rq (struct seq_file *m,struct rq *rq,int rq_cpu,u64 now)
Quoted 3 lines · Al Viro
C99 6.10.3[11]: preprocessing directive within the argument list
of macro invocation => undefined behaviour. Don't do that...
String concatenation ("a" "b") is not a preprocessing directive.
$ gcc -E test.c
# 1 "test.c"
# 1 "<built-in>"
# 1 "<command line>"
# 1 "test.c"
printf("a" "b");(If it was, the "a" "b" would have already been joined.)
Jan
Quoted 7 lines · Jan Engelhardt
Quoted 3 lines · Al Viro
C99 6.10.3[11]: preprocessing directive within the argument list
of macro invocation => undefined behaviour. Don't do that...String concatenation ("a" "b") is not a preprocessing directive.
It is not, but #ifdef definitely is.
Quoted 8 lines · Jan Engelhardt
Quoted 3 lines · Al Viro
C99 6.10.3[11]: preprocessing directive within the argument list
of macro invocation => undefined behaviour. Don't do that...String concatenation ("a" "b") is not a preprocessing directive.
Quoted 9 lines
$ gcc -E test.c # 1 "test.c" # 1 "<built-in>" # 1 "<command line>" # 1 "test.c" printf("a" "b");(If it was, the "a" "b" would have already been joined.)
Yes. According to C99 5.1.1.2, string concatenation is done in Phase 6, that's after preprocessing.
Regards.
Signature · 4 lines
_ /| \'o.O' =(___)= U ack!