Skip to contentSkip to conversation

glibc and make headers_install_all provide /usr/include/scsi

PATCH In review Olaf Hering 3 participants 4 messages Aug 6, 2007 – Aug 11, 2007 SCSI

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

glibc and make headers_install_all provide /usr/include/scsi One of them has to go.

A quick diff shows no differences, expect:

scsi.h:

     glibc #define STATUS_MASK          0x3e
     Linux #define STATUS_MASK          0xfe

     glibc #define ABORT               0x06
     Linux #define ABORT_TASK_SET      0x06

sg.h:struct sg_iovec ->sg_iovec
unsigned char * in glibc
void * in Linux

glibc #define SG_DEFAULT_RETRIES 1
Linux #define SG_DEFAULT_RETRIES 0

Which copy should be provided by a distributor?

#1 lore raw
Quoted 5 lines · Olaf Hering

glibc and make headers_install_all provide /usr/include/scsi One of them has to go.

A quick diff shows no differences, expect:

..

Quoted 1 line

Which copy should be provided by a distributor?

The glibc one of course. The kernel scsi.h should never have been added to the list of exportable headers.

author
#2 lore raw

PATCH 1/1 do not export /usr/include/scsi in make headers_install

Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Olaf Hering

glibc and make headers_install_all provide /usr/include/scsi One of them has to go.

Quoted 8 lines
Quoted 1 line

A quick diff shows no differences, expect:

..

Quoted 1 line

Which copy should be provided by a distributor?

The glibc one of course. The kernel scsi.h should never have been added to the list of exportable headers.

/usr/include/scsi is provided by glibc.
Remove the scsi export from make headers_install target.

Signed-off-by Olaf Hering <[email protected]>
---
 include/Kbuild      |    1 -
 include/scsi/Kbuild |    4 ----
 2 files changed, 5 deletions(-)
include/Kbuild +0 -1
@@ -1,6 +1,5 @@
 header-y += asm-generic/
 header-y += linux/
-header-y += scsi/
 header-y += sound/
 header-y += mtd/
 header-y += rdma/
include/scsi/Kbuild deleted +0 -4
@@ -1,4 +0,0 @@
-header-y += scsi.h
-
-unifdef-y += scsi_ioctl.h
-unifdef-y += sg.h
Acked-by on v1 1/1
#3 lore raw

Re: [PATCH] do not export /usr/include/scsi in make headers_install

Quoted 13 lines · Olaf Hering
Quoted 11 lines · Christoph Hellwig
Quoted 5 lines · Olaf Hering

glibc and make headers_install_all provide /usr/include/scsi One of them has to go.

A quick diff shows no differences, expect:

..

Quoted 1 line

Which copy should be provided by a distributor?

Quoted 8 lines
Quoted 2 lines

The glibc one of course. The kernel scsi.h should never have been added to the list of exportable headers.

/usr/include/scsi is provided by glibc.
Remove the scsi export from make headers_install target.

Signed-off-by Olaf Hering <[email protected]>
Acked-by David Woodhouse <[email protected]>
Quoted 26 lines
---
 include/Kbuild      |    1 -
 include/scsi/Kbuild |    4 ----
 2 files changed, 5 deletions(-)
include/Kbuild +0 -1
@@ -1,6 +1,5 @@
 header-y += asm-generic/
 header-y += linux/
-header-y += scsi/
 header-y += sound/
 header-y += mtd/
 header-y += rdma/
include/scsi/Kbuild deleted +0 -5
@@ -1,4 +0,0 @@
-header-y += scsi.h
-
-unifdef-y += scsi_ioctl.h
-unifdef-y += sg.h
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line
dwmw2