Skip to contentSkip to conversation

remove useless/wrong P20_24XX_TSC_IRQ mux

PATCH In review David Brownell 2 participants 2 messages Aug 14, 2007 – Aug 15, 2007

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

David Brownell

author
#0 lore raw

PATCH 1/1 remove useless/wrong P20_24XX_TSC_IRQ mux

Remove bogus TSC_IRQ pinmux; it's not used, there's no pin dedicated for touchscreen (or other TSC chip) purposes, and this doesn't even look right for P20 (0x10b not 0x108, plus an IRQ would need to be a GPIO i.e. mux 3 not mux 0).

Signed-off-by David Brownell <[email protected]>
arch/arm/mach-omap2/mux.c +0 -3
@@ -106,9 +106,6 @@ MUX_CFG_24XX("G4_242X_DMAREQ3",		0x073,	
 MUX_CFG_24XX("D3_242X_DMAREQ4",		0x072,	2,	0,	0,	1)
 MUX_CFG_24XX("E3_242X_DMAREQ5",		0x071,	2,	0,	0,	1)
 
-/* TSC IRQ */
-MUX_CFG_24XX("P20_24XX_TSC_IRQ",	0x108,	0,	0,	0,	1)
-
 /* UART3 */
 MUX_CFG_24XX("K15_24XX_UART3_TX",	0x118,	0,	0,	0,	1)
 MUX_CFG_24XX("K14_24XX_UART3_RX",	0x119,	0,	0,	0,	1)
include/asm-arm/arch-omap/mux.h +0 -2
@@ -498,8 +498,6 @@ enum omap24xx_index {
 	D3_242X_DMAREQ4,
 	E3_242X_DMAREQ5,
 
-	P20_24XX_TSC_IRQ,
-
 	/* UART3 */
 	K15_24XX_UART3_TX,
 	K14_24XX_UART3_RX,
maintainer
#1 lore raw
Quoted 22 lines · David Brownell

Remove bogus TSC_IRQ pinmux; it's not used, there's no pin dedicated for touchscreen (or other TSC chip) purposes, and this doesn't even look right for P20 (0x10b not 0x108, plus an IRQ would need to be a GPIO i.e. mux 3 not mux 0).

Signed-off-by David Brownell <[email protected]>
arch/arm/mach-omap2/mux.c +0 -3
@@ -106,9 +106,6 @@ MUX_CFG_24XX("G4_242X_DMAREQ3",		0x073,	
 MUX_CFG_24XX("D3_242X_DMAREQ4",		0x072,	2,	0,	0,	1)
 MUX_CFG_24XX("E3_242X_DMAREQ5",		0x071,	2,	0,	0,	1)
 
-/* TSC IRQ */
-MUX_CFG_24XX("P20_24XX_TSC_IRQ",	0x108,	0,	0,	0,	1)
-
 /* UART3 */
 MUX_CFG_24XX("K15_24XX_UART3_TX",	0x118,	0,	0,	0,	1)
 MUX_CFG_24XX("K14_24XX_UART3_RX",	0x119,	0,	0,	0,	1)

include/asm-arm/arch-omap/mux.h enum omap24xx_index { · line 503

Quoted 8 lines
include/asm-arm/arch-omap/mux.h +0 -2
@@ -498,8 +498,6 @@ enum omap24xx_index {
 	D3_242X_DMAREQ4,
 	E3_242X_DMAREQ5,
 
-	P20_24XX_TSC_IRQ,
-
 	/* UART3 */
 	K15_24XX_UART3_TX,
 	K14_24XX_UART3_RX,

Pushing today.

Tony