Skip to contentSkip to conversation

serial: keep the DTR setting for serial console.

PATCH New Yinghai Lu 1 participant 1 message Aug 17, 2007

lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 serial: keep the DTR setting for serial console.

[PATCH] serial: keep the DTR setting for serial console.

with reverting "x86, serial: convert legacy COM ports to platform devices", we will have the serial console before the port is probled again.

uart_add_one_port==>uart_configure_port==>set_mcttrl(port, 0) will clear the DTR setting by uart_set_options(). then I will lose my output from serial console again.

So try to keep DTR in uart_configure_port()

Cc Russell King <[email protected]>
Cc Alan Cox <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Bjorn Helgaas <[email protected]>
drivers/serial/serial_core.c +2 -1
index 030a606..70f1106 100644
@@ -2117,10 +2117,11 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
 
 		/*
 		 * Ensure that the modem control lines are de-activated.
+		 * keep the DTR setting that is set in uart_set_options()
 		 * We probably don't need a spinlock around this, but
 		 */
 		spin_lock_irqsave(&port->lock, flags);
-		port->ops->set_mctrl(port, 0);
+		port->ops->set_mctrl(port, port->mctrl & TIOCM_DTR);
 		spin_unlock_irqrestore(&port->lock, flags);
 
 		/*