Skip to contentSkip to conversation

zfcp: avoid if (whatever) ; constructs.

PATCH New Swen Schillig 1 participant 1 message Aug 28, 2007

Subsystems (2)
s390 s390 zfcp driver
lore
Share & tools
lore

Swen Schillig

author
#0 lore raw

PATCH 4/10 zfcp: avoid if (whatever) ; constructs.

From: Heiko Carstens <[email protected]>

Avoid "if (whatever) ;" constructs since they seem to confuse people, even if there is a comment.

Signed-off-by Heiko Carstens <[email protected]>
Signed-off-by Swen Schillig <[email protected]>

---

 drivers/s390/scsi/zfcp_erp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/s390/scsi/zfcp_erp.c +2 -2
diff -urpN linux-2.6/drivers/s390/scsi/zfcp_erp.c linux-2.6-patched/drivers/s390/scsi/zfcp_erp.c
@@ -1687,8 +1687,8 @@ zfcp_erp_strategy_followup_actions(int a
 		break;
 
 	case ZFCP_ERP_ACTION_REOPEN_UNIT:
-		if (status == ZFCP_ERP_SUCCEEDED) ;	/* no further action */
-		else
+		/* Nothing to do if status == ZFCP_ERP_SUCCEEDED */
+		if (status != ZFCP_ERP_SUCCEEDED)
 			zfcp_erp_port_reopen_internal(unit->port, 0);
 		break;
 	}