Skip to contentSkip to conversation

hwmon: Kconfig dependency cleanups

PATCH In review Jean Delvare 3 participants 5 messages Aug 29, 2007 – Oct 6, 2007 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: Kconfig dependency cleanups

* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are custom chips which can only be found on their respective manufacturer's systems, and these manufacturers only do x86 hardware AFAIK.

---
 drivers/hwmon/Kconfig |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/hwmon/Kconfig +6 -6
@@ -30,7 +30,7 @@ config HWMON_VID
 
 config SENSORS_ABITUGURU
 	tristate "Abit uGuru (rev 1 & 2)"
-	depends on EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
 	help
 	  If you say yes here you get support for the sensor part of the first
 	  and second revision of the Abit uGuru chip. The voltage and frequency
@@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
 
 config SENSORS_ABITUGURU3
 	tristate "Abit uGuru (rev 3)"
-	depends on HWMON && EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
 	help
 	  If you say yes here you get support for the sensor part of the
 	  third revision of the Abit uGuru chip. Only reading the sensors
@@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
 
 config SENSORS_ASB100
 	tristate "Asus ASB100 Bach"
-	depends on I2C && EXPERIMENTAL
+	depends on X86 && I2C && EXPERIMENTAL
 	select HWMON_VID
 	help
 	  If you say yes here you get support for the ASB100 Bach sensor
@@ -248,7 +248,7 @@ config SENSORS_F75375S
 
 config SENSORS_FSCHER
 	tristate "FSC Hermes"
-	depends on I2C
+	depends on X86 && I2C
 	help
 	  If you say yes here you get support for Fujitsu Siemens
 	  Computers Hermes sensor chips.
@@ -258,7 +258,7 @@ config SENSORS_FSCHER
 
 config SENSORS_FSCPOS
 	tristate "FSC Poseidon"
-	depends on I2C
+	depends on X86 && I2C
 	help
 	  If you say yes here you get support for Fujitsu Siemens
 	  Computers Poseidon sensor chips.
@@ -431,7 +431,7 @@ config SENSORS_LM92
 
 config SENSORS_LM93
 	tristate "National Semiconductor LM93 and compatibles"
-	depends on HWMON && I2C
+	depends on I2C
 	select HWMON_VID
 	help
 	  If you say yes here you get support for National Semiconductor LM93
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Hi All,

In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html

Jean Delvare wrote:
--------------------------------------------
* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are custom chips which can only be found on their respective manufacturer's systems, and these manufacturers only do x86 hardware AFAIK.

Signed-off-by Jean Delvare <khali at linux-fr.org>
---
  drivers/hwmon/Kconfig |   12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
drivers/hwmon/Kconfig +6 -6
@@ -30,7 +30,7 @@ config HWMON_VID
 
  config SENSORS_ABITUGURU
  	tristate "Abit uGuru (rev 1 & 2)"
-	depends on EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
  	help
  	  If you say yes here you get support for the sensor part of the first
  	  and second revision of the Abit uGuru chip. The voltage and frequency
@@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
 
  config SENSORS_ABITUGURU3
  	tristate "Abit uGuru (rev 3)"
-	depends on HWMON && EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
  	help
  	  If you say yes here you get support for the sensor part of the
  	  third revision of the Abit uGuru chip. Only reading the sensors
@@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
 
  config SENSORS_ASB100
  	tristate "Asus ASB100 Bach"
-	depends on I2C && EXPERIMENTAL
+	depends on X86 && I2C && EXPERIMENTAL
  	select HWMON_VID
  	help
  	  If you say yes here you get support for the ASB100 Bach sensor
@@ -248,7 +248,7 @@ config SENSORS_F75375S
 
  config SENSORS_FSCHER
  	tristate "FSC Hermes"
-	depends on I2C
+	depends on X86 && I2C
  	help
  	  If you say yes here you get support for Fujitsu Siemens
  	  Computers Hermes sensor chips.
@@ -258,7 +258,7 @@ config SENSORS_FSCHER
 
  config SENSORS_FSCPOS
  	tristate "FSC Poseidon"
-	depends on I2C
+	depends on X86 && I2C
  	help
  	  If you say yes here you get support for Fujitsu Siemens
  	  Computers Poseidon sensor chips.
@@ -431,7 +431,7 @@ config SENSORS_LM92
 
  config SENSORS_LM93
  	tristate "National Semiconductor LM93 and compatibles"
-	depends on HWMON && I2C
+	depends on I2C
  	select HWMON_VID
  	help
  	  If you say yes here you get support for National Semiconductor LM93
Signature · 15 lines
Jean Delvare

-------------------------------------------------------------

One beginner question, does X86 also get defined on x86_64? If not this won't work.

Regards,

Hans


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw
In reply to Jean Delvare

Hi Hans,

Quoted 75 lines · Hans de Goede

In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html

Jean Delvare wrote:
--------------------------------------------
* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are custom chips which can only be found on their respective manufacturer's systems, and these manufacturers only do x86 hardware AFAIK.

Signed-off-by Jean Delvare <khali at linux-fr.org>
---
  drivers/hwmon/Kconfig |   12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
drivers/hwmon/Kconfig +6 -7
@@ -30,7 +30,7 @@ config HWMON_VID
 
  config SENSORS_ABITUGURU
  	tristate "Abit uGuru (rev 1 & 2)"
-	depends on EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
  	help
  	  If you say yes here you get support for the sensor part of the first
  	  and second revision of the Abit uGuru chip. The voltage and frequency
@@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
 
  config SENSORS_ABITUGURU3
  	tristate "Abit uGuru (rev 3)"
-	depends on HWMON && EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
  	help
  	  If you say yes here you get support for the sensor part of the
  	  third revision of the Abit uGuru chip. Only reading the sensors
@@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
 
  config SENSORS_ASB100
  	tristate "Asus ASB100 Bach"
-	depends on I2C && EXPERIMENTAL
+	depends on X86 && I2C && EXPERIMENTAL
  	select HWMON_VID
  	help
  	  If you say yes here you get support for the ASB100 Bach sensor
@@ -248,7 +248,7 @@ config SENSORS_F75375S
 
  config SENSORS_FSCHER
  	tristate "FSC Hermes"
-	depends on I2C
+	depends on X86 && I2C
  	help
  	  If you say yes here you get support for Fujitsu Siemens
  	  Computers Hermes sensor chips.
@@ -258,7 +258,7 @@ config SENSORS_FSCHER
 
  config SENSORS_FSCPOS
  	tristate "FSC Poseidon"
-	depends on I2C
+	depends on X86 && I2C
  	help
  	  If you say yes here you get support for Fujitsu Siemens
  	  Computers Poseidon sensor chips.
@@ -431,7 +431,7 @@ config SENSORS_LM92
 
  config SENSORS_LM93
  	tristate "National Semiconductor LM93 and compatibles"
-	depends on HWMON && I2C
+	depends on I2C
  	select HWMON_VID
  	help
  	  If you say yes here you get support for National Semiconductor LM93
 
-------------------------------------------------------------
Quoted 1 line

One beginner question, does X86 also get defined on x86_64? If not this won't work.

Yes, it does get defined. i386 gets X86 and X86_32, x86_64 gets X86 and X86_64.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Acked-by on v1 1/1
#3 lore raw
In reply to Jean Delvare

Hi All,

In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html

Jean Delvare wrote:
--------------------------------------------
* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are custom chips which can only be found on their respective manufacturer's systems, and these manufacturers only do x86 hardware AFAIK.

Signed-off-by Jean Delvare <khali at linux-fr.org>
---
  drivers/hwmon/Kconfig |   12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
drivers/hwmon/Kconfig +6 -6
@@ -30,7 +30,7 @@ config HWMON_VID
 
  config SENSORS_ABITUGURU
  	tristate "Abit uGuru (rev 1 & 2)"
-	depends on EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
  	help
  	  If you say yes here you get support for the sensor part of the first
  	  and second revision of the Abit uGuru chip. The voltage and frequency
@@ -45,7 +45,7 @@ config SENSORS_ABITUGURU
 
  config SENSORS_ABITUGURU3
  	tristate "Abit uGuru (rev 3)"
-	depends on HWMON && EXPERIMENTAL
+	depends on X86 && EXPERIMENTAL
  	help
  	  If you say yes here you get support for the sensor part of the
  	  third revision of the Abit uGuru chip. Only reading the sensors
@@ -182,7 +182,7 @@ config SENSORS_AMS_I2C
 
  config SENSORS_ASB100
  	tristate "Asus ASB100 Bach"
-	depends on I2C && EXPERIMENTAL
+	depends on X86 && I2C && EXPERIMENTAL
  	select HWMON_VID
  	help
  	  If you say yes here you get support for the ASB100 Bach sensor
@@ -248,7 +248,7 @@ config SENSORS_F75375S
 
  config SENSORS_FSCHER
  	tristate "FSC Hermes"
-	depends on I2C
+	depends on X86 && I2C
  	help
  	  If you say yes here you get support for Fujitsu Siemens
  	  Computers Hermes sensor chips.
@@ -258,7 +258,7 @@ config SENSORS_FSCHER
 
  config SENSORS_FSCPOS
  	tristate "FSC Poseidon"
-	depends on I2C
+	depends on X86 && I2C
  	help
  	  If you say yes here you get support for Fujitsu Siemens
  	  Computers Poseidon sensor chips.
@@ -431,7 +431,7 @@ config SENSORS_LM92
 
  config SENSORS_LM93
  	tristate "National Semiconductor LM93 and compatibles"
-	depends on HWMON && I2C
+	depends on I2C
  	select HWMON_VID
  	help
  	  If you say yes here you get support for National Semiconductor LM93

-------------------------------------------------------------

Quoted 4 lines · Jean Delvare

Hi Hans,

Quoted 1 line · Hans de Goede

One beginner question, does X86 also get defined on x86_64? If not this

won't work.

Quoted 4 lines

Yes, it does get defined. i386 gets X86 and X86_32, x86_64 gets X86 and X86_64.

In that case, its fine:

Regards,

Hans

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Jean Delvare

Hi:

Quoted 14 lines · Hans de Goede

Hi All,

In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-August/021089.html

Jean Delvare wrote:
--------------------------------------------
* Drop HWMON from the dependency list of ABITUGURU3 and LM93: this is now handled at menu level.
* Make the Abit, Asus and FSC chip drivers depend on X86. These are custom chips which can only be found on their respective manufacturer's systems, and these manufacturers only do x86 hardware AFAIK.

Signed-off-by Jean Delvare <khali at linux-fr.org>

(...)

Quoted 1 line

Applied to hwmon-2.6.git/testing, thanks.

Signature · 8 lines
Mark M. Hoffman
[email protected]


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors