Skip to contentSkip to conversation

ALSA: cs5535audio fixes

PATCH In review Andres Salomon 4 participants 4 messages Aug 30, 2007

lore
Share & tools
lore
#0 lore raw

cover ALSA: cs5535audio fixes

Hi,

Here are a bunch of fixes for the cs5535audio driver. None of these are OLPC specific; generic chip and power management fixes, and one cleanup patch. All have been tested on an OLPC (5536), so even though the 5535 data sheet claims to be the same, it would be nice to hear success/failure reports from someone with a 5535.

Signature · 1 line
Andres Salomon <[email protected]>
Acked-by on the v1 series
#1 lore raw
Quoted 7 lines · Andres Salomon

Hi,

Here are a bunch of fixes for the cs5535audio driver. None of these are OLPC specific; generic chip and power management fixes, and one cleanup patch. All have been tested on an OLPC (5536), so even though the 5535 data sheet claims to be the same, it would be nice to hear success/failure reports from someone with a 5535.

The patches look good. I'm traveling till Sep 2nd so can't test on 5535 yet. Thanks very much for your efforts Andres.

Thanks,
jaya

#2 lore raw

At Wed, 29 Aug 2007 23:52:08 -0400,

Quoted 4 lines · Jaya Kumar
Quoted 2 lines · Andres Salomon

Hi,

Quoted 8 lines
Quoted 5 lines

Here are a bunch of fixes for the cs5535audio driver. None of these are OLPC specific; generic chip and power management fixes, and one cleanup patch. All have been tested on an OLPC (5536), so even though the 5535 data sheet claims to be the same, it would be nice to hear success/failure reports from someone with a 5535.

The patches look good. I'm traveling till Sep 2nd so can't test on 5535 yet. Thanks very much for your efforts Andres.

OK, let me know if it works for you. Then I'll apply them to ALSA tree.

Thanks,

Takashi

#3 lore raw
In reply to Andres Salomon
Quoted 7 lines · Andres Salomon

Hi,

Here are a bunch of fixes for the cs5535audio driver. None of these are OLPC specific; generic chip and power management fixes, and one cleanup patch. All have been tested on an OLPC (5536), so even though the 5535 data sheet claims to be the same, it would be nice to hear success/failure reports from someone with a 5535.

These look good - and they should work fine on the 5535 - none of the patches really change how we touch the hardware, just when we touch the hardware.

5536 is by far the more popular chip now, so I recommend we put these in, and if by some unlucky coincidence a 5535 bug pops up, we'll deal with it when it happens.

Jordan

Signature · 3 lines
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.