mpc5200: switch to CONFIG_OF_LIBFDT
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using OF_FLAT_TREE to OF_LIBFDT. It also fixes the compile of cm5200.
It's been tested on the lite5200.
Still to be resolved: is there a better place to put the helper functions.
---
board/icecube/icecube.c | 10 ++++--- board/tqm5200/tqm5200.c | 12 +++++--- cpu/mpc5xxx/cpu.c | 67 ++++++++++++++++++++++++++++----------------- include/configs/IceCube.h | 2 + include/configs/TQM5200.h | 2 + 5 files changed, 57 insertions(+), 36 deletions(-)
board/icecube/icecube.c +6 -4
@@ -29,9 +29,11 @@#include <pci.h> #include <asm/processor.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h> +#endif /* CONFIG_OF_LIBFDT */ #if defined(CONFIG_LITE5200B )#include "mt46v32m16.h"
@@ -386,7 +388,7 @@ void ide_set_reset (int idereset) }#endif -#if defined(CONFIG_OF_FLAT_TREE ) && defined(CONFIG_OF_BOARD_SETUP ) +#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )void ft_board_setup (void *blob,bd_t *bd) {
board/tqm5200/tqm5200.c +7 -5
@@ -32,9 +32,11 @@#include <pci.h> #include <asm/processor.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h> +#endif /* CONFIG_OF_LIBFDT */ #ifdef CONFIG_VIDEO_SM501 #include <sm501.h>
@@ -780,9 +782,9 @@ int board_get_height (void)#endif /* CONFIG_VIDEO_SM501 */ -#if defined(CONFIG_OF_FLAT_TREE ) && defined(CONFIG_OF_BOARD_SETUP ) +#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )void ft_board_setup (void *blob,bd_t *bd) {ft_cpu_setup (blob, bd); } -#endif /* defined(CONFIG_OF_FLAT_TREE) && defined(CONFIG_OF_BOARD_SETUP) */ +#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
cpu/mpc5xxx/cpu.c +42 -25
79 lines not on this page · raw message
include/configs/IceCube.h +1 -1
@@ -178,7 +178,7 @@#endif /* CONFIG_MPC5200 */ /* pass open firmware flat tree */ -#define CONFIG_OF_FLAT_TREE 1 +#define CONFIG_OF_LIBFDT 1#define CONFIG_OF_BOARD_SETUP 1#define OF_CPU "PowerPC,5200 at 0"
include/configs/TQM5200.h +1 -1
@@ -701,7 +701,7 @@* Open firmware flat tree support *----------------------------------------------------------------------- */ -#define CONFIG_OF_FLAT_TREE 1 +#define CONFIG_OF_LIBFDT 1#define CONFIG_OF_BOARD_SETUP 1#define OF_CPU "PowerPC,5200 at 0"
Quoted 8 lines · On Thu, 30 Aug 2007 12:20:14 -0600 Grant Likely <[email protected]>…
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Still to be resolved: is there a better place to put the helper functions.
the way you've done them, they probably belong in libfdt space.
Quoted 6 lines
board/icecube/icecube.c +0
-0@@ -29,9 +29,11 @@#include <pci.h>
board/icecube/icecube.c line 36
Quoted 10 lines
board/icecube/icecube.c +4
-3#include <asm/processor.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h>
you really don't need (or want) the above two.
Quoted 7 lines
board/icecube/icecube.c +1
-0+#endif /* CONFIG_OF_LIBFDT */ board/tqm5200/tqm5200.c +0
-0
board/tqm5200/tqm5200.c line 38
Quoted 10 lines
board/tqm5200/tqm5200.c +4
-3@@ -32,9 +32,11 @@#include <pci.h> #include <asm/processor.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h>
ditto.
board/tqm5200/tqm5200.c line 39
Quoted 1 line
board/tqm5200/tqm5200.c +1
-0+#endif /* CONFIG_OF_LIBFDT */
do the includes need such protection?
board/tqm5200/tqm5200.c
Quoted 4 lines
board/tqm5200/tqm5200.c +4
-0+void ft_cpu_setup (void *blob,bd_t *bd) +{ +char * cpu_path ="/cpus/" OF_CPU ; +char * eth_path ="/" OF_SOC "/ethernet at 3000" ;
s/char * /char */
actually, we should get rid of OF_CPU, and OF_SOC altogether. fdt_find_node_by_type "cpu" and "soc" should be used instead. The cpu update code probably belongs in lib_ppc.
Kim
Quoted 28 lines · Kim Phillips
Quoted 8 lines · On Thu, 30 Aug 2007 12:20:14 -0600 Grant Likely <[email protected]>…
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Still to be resolved: is there a better place to put the helper functions.
the way you've done them, they probably belong in libfdt space.
Quoted 13 lines
board/icecube/icecube.c +2
-3@@ -29,9 +29,11 @@#include <pci.h> #include <asm/processor.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h>
Quoted 4 lines
board/icecube/icecube.c line 35
Quoted 2 lines
board/icecube/icecube.c +2
-0+#include <libfdt_env.h> +#include <fdt_support.h> you really don't need (or want) the above two.
Okay, I'll pull them out.
Quoted 10 lines
board/icecube/icecube.c line 35
Quoted 7 lines
board/icecube/icecube.c +4
-3-#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h> ditto.
Quoted 3 lines
Quoted 1 line
+#endif /*
CONFIG_OF_LIBFDT*/do the includes need such protection?
There are a number of 5200 boards that haven't been migrated to support fdt yet, so I left the protection in. I suppose it can be removed.
Quoted 11 lines
board/icecube/icecube.c
Quoted 5 lines
board/icecube/icecube.c +4
-0+void ft_cpu_setup (void *blob,bd_t *bd) +{ +char * cpu_path ="/cpus/" OF_CPU ; +char * eth_path ="/" OF_SOC "/ethernet at 3000" ;s/char * /char */
actually, we should get rid of
OF_CPU, andOF_SOCaltogether.fdt_find_node_by_type"cpu" and "soc" should be used instead. The cpu update code probably belongs inlib_ppc.
Sure, but if it's okay by you, I'd like to do that in another patch. In this case, I want to minimize the impact to 5xxx boards.
Thanks,
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 46 lines · Grant Likely
Quoted 28 lines · Kim Phillips
Quoted 8 lines · On Thu, 30 Aug 2007 12:20:14 -0600 Grant Likely <[email protected]>…
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Still to be resolved: is there a better place to put the helper functions.
the way you've done them, they probably belong in libfdt space.
Quoted 13 lines
board/icecube/icecube.c +2
-3@@ -29,9 +29,11 @@#include <pci.h> #include <asm/processor.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> Quoted 4 lines
board/icecube/icecube.c line 35
Quoted 2 lines
board/icecube/icecube.c +2
-0+#include <libfdt_env.h> +#include <fdt_support.h> you really don't need (or want) the above two.
Okay, I'll pull them out.
Quoted 10 lines
board/icecube/icecube.c line 35
Quoted 7 lines
board/icecube/icecube.c +4
-3-#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h> ditto.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
+#endif /*
CONFIG_OF_LIBFDT*/do the includes need such protection?
There are a number of 5200 boards that haven't been migrated to support fdt yet, so I left the protection in. I suppose it can be removed.
Ignore this comment; I was on crack.. Of course the protections are not needed for the board specific code. I'll fix.
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Grant Likely wrote:
[...]
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
board/icecube/icecube.c line 35
Quoted 7 lines
board/icecube/icecube.c +4
-3-#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h> ditto.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line
+#endif /*
CONFIG_OF_LIBFDT*/do the includes need such protection?
There are a number of 5200 boards that haven't been migrated to support fdt yet, so I left the protection in. I suppose it can be removed.
Ignore this comment; I was on crack.. Of course the protections are not needed for the board specific code. I'll fix.
Could similar protections around ft_board_setup() definition in board-specific code be removed as well? I'm thinking about:
#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) void ft_board_setup(void *blob, bd_t *bd)
{
ft_cpu_setup(blob, bd);
}#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
Regards,
Bartlomiej
Quoted 23 lines · Bartlomiej Sieka
Grant Likely wrote:
[...]Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
board/icecube/icecube.c line 35
Quoted 7 lines
board/icecube/icecube.c +4
-3-#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#ifdef CONFIG_OF_LIBFDT +#include <libfdt.h> +#include <libfdt_env.h> +#include <fdt_support.h> ditto.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line
+#endif /*
CONFIG_OF_LIBFDT*/do the includes need such protection?
There are a number of 5200 boards that haven't been migrated to support fdt yet, so I left the protection in. I suppose it can be removed.
Ignore this comment; I was on crack.. Of course the protections are not needed for the board specific code. I'll fix.
Could similar protections around
ft_board_setup()definition in board-specific code be removed as well? I'm thinking about:
Quoted 6 lines
#if
defined(CONFIG_OF_LIBFDT)&&defined(CONFIG_OF_BOARD_SETUP)voidft_board_setup(void *blob, bd_t *bd){ ft_cpu_setup(blob, bd); }#endif /*
defined(CONFIG_OF_LIBFDT)&&defined(CONFIG_OF_BOARD_SETUP)*/
I considered this, but ultimately decided not to do it (yet). It is still possible that someone will want to configure one of these boards without fdt support. In this case, the protection around the includes is benign, but ft_board_setup is not.
Also, there are some boards which use the tqm5200 board code, but whose config file is not setup to use LIBFDT.
Cheers,
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 6 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to OF_LIBFDT.
Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Regards,
Bartlomiej
board/motionpro/motionpro.c +3 -5
@@ -29,9 +29,7 @@#include <common.h> #include <mpc5xxx.h> #include <miiphy.h> -#if defined(CONFIG_OF_FLAT_TREE ) -#include <ft_build.h> -#endif +#include <libfdt.h> #if defined(CONFIG_STATUS_LED )#include <status_led.h>
@@ -196,12 +194,12 @@ int checkboard(void) } -#if defined(CONFIG_OF_FLAT_TREE ) && defined(CONFIG_OF_BOARD_SETUP ) +#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )void ft_board_setup (void *blob,bd_t *bd) {ft_cpu_setup (blob, bd); } -#endif /* defined(CONFIG_OF_FLAT_TREE) && defined(CONFIG_OF_BOARD_SETUP) */ +#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */ #if defined(CONFIG_STATUS_LED )
include/configs/motionpro.h +1 -1
@@ -417,7 +417,7 @@ extern void __led_set(led_id_t id, int state);#define CFG_RESET_ADDRESS 0xfff00100/* pass open firmware flat tree */ -#define CONFIG_OF_FLAT_TREE 1 +#define CONFIG_OF_LIBFDT 1#define CONFIG_OF_BOARD_SETUP 1#define OF_CPU "PowerPC,5200 at 0"
Quoted 6 lines · Bartlomiej Sieka
Quoted 5 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.
Quoted 6 lines
Quoted 1 line
It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to
OF_LIBFDT.Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Can do. I'll respin the patch and post it once more to the list before asking wd to pull it.
Cheers,
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 10 lines · Grant Likely
Quoted 9 lines · Bartlomiej Sieka
Quoted 6 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to
OF_LIBFDT.
Quoted 8 lines
Quoted 2 lines
Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Can do. I'll respin the patch and post it once more to the list before asking wd to pull it.
Cheers,
g.
Hi Grant,
My only critique/request is to change fixup_int_prop() to be fixup_u32_prop() so that we don't get confused if we ever have to fix up a u16 or u64 property.
Thanks,
gvb
Quoted 17 lines · Jerry Van Baren
Quoted 16 lines · Grant Likely
Quoted 11 lines · Bartlomiej Sieka
Quoted 6 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to
OF_LIBFDT.Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Can do. I'll respin the patch and post it once more to the list before asking wd to pull it.
Quoted 8 lines
Quoted 2 lines
Cheers,
g.Hi Grant,
My only critique/request is to change
fixup_int_prop()to befixup_u32_prop()so that we don't get confused if we ever have to fix up a u16 or u64 property.
No problem. Should I move it to libfdt as well?
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 21 lines · Grant Likely
Quoted 20 lines · Jerry Van Baren
Quoted 10 lines · Grant Likely
Quoted 9 lines · Bartlomiej Sieka
Quoted 6 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to
OF_LIBFDT.Quoted 7 lines
Quoted 2 lines
Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Can do. I'll respin the patch and post it once more to the list before asking wd to pull it.
Cheers,
g.Hi Grant,
Quoted 7 lines
Quoted 3 lines
My only critique/request is to change
fixup_int_prop()to befixup_u32_prop()so that we don't get confused if we ever have to fix up a u16 or u64 property.No problem. Should I move it to libfdt as well?
g.
Sure!
We have a 3-way coordination between you, Kim with the 83xx, and myself with libfdt and right now I'm pretty busy. I have not had the time to figure out where the routine should go and get together a set of patches for libfdt and 83xx to convert over to the New Improved helper routines.
If you are willing to figure out where to put it in libfdt, I'll push forward from this end but it may be a couple of weeks before I can put some time in on it (unless my more "urgent" duties get boring ;-).
In the last merge window, Kim & I traded some patches back and forth and git figured it out OK, so we should be able to apply the same patch to both your and my (and Kim's?) repositories and have it all work out.
Thanks,
gvb
Quoted 37 lines · Jerry Van Baren
Quoted 21 lines · Grant Likely
Quoted 20 lines · Jerry Van Baren
Quoted 10 lines · Grant Likely
Quoted 9 lines · Bartlomiej Sieka
Quoted 6 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to
OF_LIBFDT.Quoted 7 lines
Quoted 2 lines
Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Can do. I'll respin the patch and post it once more to the list before asking wd to pull it.
Cheers,
g.Hi Grant,
Quoted 7 lines
Quoted 3 lines
My only critique/request is to change
fixup_int_prop()to befixup_u32_prop()so that we don't get confused if we ever have to fix up a u16 or u64 property.No problem. Should I move it to libfdt as well?
g.
Sure!
We have a 3-way coordination between you, Kim with the 83xx, and myself with libfdt and right now I'm pretty busy. I have not had the time to figure out where the routine should go and get together a set of patches for libfdt and 83xx to convert over to the New Improved helper routines.
Quoted 7 lines
If you are willing to figure out where to put it in libfdt, I'll push forward from this end but it may be a couple of weeks before I can put some time in on it (unless my more "urgent" duties get boring ;-).
In the last merge window, Kim & I traded some patches back and forth and git figured it out OK, so we should be able to apply the same patch to both your and my (and Kim's?) repositories and have it all work out.
Alright, I'll do so. Where does the 'upstream' libfdt source live nowdays? Do you want me to craft the change against the u-boot repo and let you merge it back in to libfdt upstream? Or should I put a temporary change into u-boot to fix the compile issues and base my patch against libfdt upstream (with the mind to remove the temporary fix when u-boot resyncs)?
Cheers,
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 51 lines · Grant Likely
Quoted 35 lines · Jerry Van Baren
Quoted 19 lines · Grant Likely
Quoted 18 lines · Jerry Van Baren
Quoted 17 lines · Grant Likely
Quoted 11 lines · Bartlomiej Sieka
Quoted 6 lines · Grant Likely
From: Grant Likely <[email protected]>
Here is a patch which converts the icecube* and tqm5200 boards from using
OF_FLAT_TREEtoOF_LIBFDT. It also fixes the compile of cm5200.It's been tested on the lite5200.
Tested also on motionpro, with the below patch that converts it to
OF_LIBFDT.Grant: perhaps it would be a good idea to merge this patch with your upcoming updated patch for icecube and tqm5200?
Can do. I'll respin the patch and post it once more to the list before asking wd to pull it.
Cheers,
g.Quoted 8 lines
Quoted 5 lines
Hi Grant,
My only critique/request is to change
fixup_int_prop()to befixup_u32_prop()so that we don't get confused if we ever have to fix up a u16 or u64 property.No problem. Should I move it to libfdt as well?
g.
Sure!
We have a 3-way coordination between you, Kim with the 83xx, and myself with libfdt and right now I'm pretty busy. I have not had the time to figure out where the routine should go and get together a set of patches for libfdt and 83xx to convert over to the New Improved helper routines.
Quoted 7 lines
If you are willing to figure out where to put it in libfdt, I'll push forward from this end but it may be a couple of weeks before I can put some time in on it (unless my more "urgent" duties get boring ;-).
In the last merge window, Kim & I traded some patches back and forth and git figured it out OK, so we should be able to apply the same patch to both your and my (and Kim's?) repositories and have it all work out.
Alright, I'll do so. Where does the 'upstream' libfdt source live nowdays? Do you want me to craft the change against the u-boot repo and let you merge it back in to libfdt upstream? Or should I put a temporary change into u-boot to fix the compile issues and base my patch against libfdt upstream (with the mind to remove the temporary fix when u-boot resyncs)?
Quoted 2 lines
Cheers,
g.
Hi Grant,
The libfdt custodian repo is on the denx.de site, but should be the same as the mainline. I would say patch your 5xxx custodian repo, publishing the new functions that impact the libfdt stuff as a separate patch and The List can discuss them. I'll "ack" them and apply them to my repo as well, but NBD. I will plan on updating the 83xx implementation(s) and publish them for Kim to ack/adopt as well.
When we get the basics of the New Improved[tm] utility functions set up, we can redo the 83xx at our leisure.
Best regards,
gvb
Quoted 9 lines · Jerry Van Baren
Hi Grant,
The libfdt custodian repo is on the denx.de site, but should be the same as the mainline. I would say patch your 5xxx custodian repo, publishing the new functions that impact the libfdt stuff as a separate patch and The List can discuss them. I'll "ack" them and apply them to my repo as well, but NBD. I will plan on updating the 83xx implementation(s) and publish them for Kim to ack/adopt as well.
Ah, okay. I was more wondering if there was a libfdt repo that was upstream and separate from u-boot (as dtc uses libfdt also). Okay, I'll rebase against wd's mainline and repost ASAP.
Cheers,
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 11 lines · Grant Likely
Quoted 9 lines · Jerry Van Baren
Hi Grant,
The libfdt custodian repo is on the denx.de site, but should be the same as the mainline. I would say patch your 5xxx custodian repo, publishing the new functions that impact the libfdt stuff as a separate patch and The List can discuss them. I'll "ack" them and apply them to my repo as well, but NBD. I will plan on updating the 83xx implementation(s) and publish them for Kim to ack/adopt as well.
Quoted 3 lines
Ah, okay. I was more wondering if there was a libfdt repo that was upstream and separate from u-boot (as dtc uses libfdt also). Okay, I'll rebase against wd's mainline and repost ASAP.
Hmmm. On a third reading, I don't think the fixup functions belong in libfdt, or at least not completely. I'll add a function 'fdt_find_and_setprop()' which handles the logic, but I'll keep a couple of helpers in cpu/mpc5200/cpu.c just because they involve printf() calls for user feedback and printf() calls don't really belong in libfdt.
Cheers,
g.
Quoted 10 lines
Cheers,
g.--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
Quoted 10 lines · Grant Likely
Quoted 8 lines · Jerry Van Baren
Hi Grant,
The libfdt custodian repo is on the denx.de site, but should be the same as the mainline. I would say patch your 5xxx custodian repo, publishing the new functions that impact the libfdt stuff as a separate patch and The List can discuss them. I'll "ack" them and apply them to my repo as well, but NBD. I will plan on updating the 83xx implementation(s) and publish them for Kim to ack/adopt as well.
Quoted 6 lines
Ah, okay. I was more wondering if there was a libfdt repo that was upstream and separate from u-boot (as dtc uses libfdt also). Okay, I'll rebase against wd's mainline and repost ASAP.
Cheers,
g.
Ahh, now I see what you were asking. When I ported libfdt to u-boot, I ended up forking it because the official libfdt did not have all the functionality we needed and, at the time, David Gibson was not taking patches. He was working on setting up a dual-licensing for libfdt and did not want changes before the lawyers were happy with the licensing.
David has since slain the licensing dragon, but we have not unforked libfdt.
To unfork, we have a couple of issues to work out. One is the amount of effort to undo the divergence (probably not bad). The other is the dual-licensing issue: David added a BSD license. Most of the new code is from me, but some is from others (Wolfgang G.) and some of it was shamelessly stolen from linux's FDT support (not LIBFDT). In order to unfork, we would have to have agreement from the authors of the additional code to relicense with the dual license... or maybe Jon and David have independently written equivalent routines (quite possible).
Best regards,
gvb
Quoted 2 lines · Jerry Van Baren
Ahh, now I see what you were asking. When I ported libfdt to u-boot, I ended up forking it
...
Quoted 3 lines
To unfork, we have a couple of issues to work out. One is the amount of effort to undo the divergence (probably not bad). The other is the dual-licensing issue:
...
Quoted 4 lines
In order to
unfork, we would have to have agreement from the authors of the additional code to relicense with the dual license... or maybe Jon and David have independently written equivalent routines (quite possible).
Right.
Jon has recently been busy staring into Cardiac ICUs, getting a split tooth repaired, and breaking his big toe. No actual coding is taking place, unfortunately. :-)
jdl
PS -- All I need now is someone to staring using "u" instead of "you"
to set me off...
Quoted 3 lines · Jon Loeliger
PS -- All I need now is someone to staring using "u" instead of "you"
to set me off...
And apparently drinking too.
s/staring/start/
Sheesh.
jdl
Quoted 5 lines · Jon Loeliger
jdl
PS -- All I need now is someone to staring using "u" instead of "you"
to set me off...
u just need to relax.
g.
Signature · 4 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195