Skip to contentSkip to conversation

CIFS: respect umask when using POSIX mkdir

PATCH New Jeff Layton 1 participant 1 message Sep 12, 2007 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CIFS: respect umask when using POSIX mkdir

When making a directory with POSIX mkdir calls, cifs_mkdir does not respect the umask. This moves the AND'ing of the mode with the umask to higher in the function so that the POSIX mkdir creates with the correct mode.

---
 fs/cifs/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/cifs/inode.c +1 -1
index 66436f5..260ab4e 100644
@@ -908,6 +908,7 @@ int cifs_mkdir(struct inode *inode, struct dentry *direntry, int mode)
 		return -ENOMEM;
 	}
 
+	mode &= ~current->fs->umask;
 	if ((pTcon->ses->capabilities & CAP_UNIX) &&
 		(CIFS_UNIX_POSIX_PATH_OPS_CAP &
 			le64_to_cpu(pTcon->fsUnixInfo.Capability))) {
@@ -999,7 +1000,6 @@ mkdir_get_info:
 		if ((direntry->d_inode) && (direntry->d_inode->i_nlink < 2))
 				direntry->d_inode->i_nlink = 2;
 		if (pTcon->unix_ext) {
-			mode &= ~current->fs->umask;
 			if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID) {
 				CIFSSMBUnixSetPerms(xid, pTcon, full_path,
 						    mode,
Signature · 1 line
1.5.2.1