Configure cpuidle governors by default

Quoting Len "Do not give an option to users to shoot themselves in the foot".

Remove the configurability of ladder and menu governors as they are needed for default policy of cpuidle. That way users will not be able to have cpuidle without any policy loosing all C-state power savings.

Index: linux-2.6.23-rc6/drivers/cpuidle/Kconfig
===================================================================
@@ -1,4 +1,3 @@
-menu "CPU idle PM support"
 
 config CPU_IDLE
 	bool "CPU idle PM support"

@@ -10,30 +9,13 @@ config CPU_IDLE
 	  If you're using a mobile platform that supports CPU idle PM (e.g.
 	  an ACPI-capable notebook), you should say Y here.
 
-if CPU_IDLE
-
-comment "Governors"
-
 config CPU_IDLE_GOV_LADDER
-	tristate "'ladder' governor"
+	bool
 	depends on CPU_IDLE
 	default y
-	help
-	  This cpuidle governor promotes and demotes through the supported idle
-	  states using residency time and bus master activity as metrics.  This
-	  algorithm was originally introduced in the old ACPI processor driver.
 
 config CPU_IDLE_GOV_MENU
-	tristate "'menu' governor"
+	bool
 	depends on CPU_IDLE && NO_HZ
 	default y
-	help
-	  This cpuidle governor evaluates all available states and chooses the
-	  deepest state that meets all of the following constraints: BM activity,
-	  expected time until next timer interrupt, and last break event time
-	  delta.  It is designed to minimize power consumption.  Currently
-	  dynticks is required.
-
-endif	# CPU_IDLE
 
-endmenu

the foot".

Odd, I thought that was a Windows attitude, and Unix/Linux was the opposite.

"All the rope and more..."

Bob

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Venki Pallipadi
Sent: Thursday, September 13, 2007 1:39 PM
To: Brown, Len
Cc: [email protected]; [email protected]
Subject: [PATCH] Configure cpuidle governors by default

Quoting Len "Do not give an option to users to shoot themselves in the foot".

Remove the configurability of ladder and menu governors as they are needed for default policy of cpuidle. That way users will not be able to have cpuidle without any policy loosing all C-state power savings.

Index: linux-2.6.23-rc6/drivers/cpuidle/Kconfig
===================================================================
@@ -1,4 +1,3 @@
-menu "CPU idle PM support"
 
 config CPU_IDLE
 	bool "CPU idle PM support"

@@ -10,30 +9,13 @@ config CPU_IDLE
 	  If you're using a mobile platform that supports CPU idle PM

(e.g.
an ACPI-capable notebook), you should say Y here.

-if CPU_IDLE
-
-comment "Governors"
-
config CPU_IDLE_GOV_LADDER
- tristate "'ladder' governor"
+ bool
depends on CPU_IDLE
default y
- help
- This cpuidle governor promotes and demotes through the
supported idle
- states using residency time and bus master activity as
metrics. This
- algorithm was originally introduced in the old ACPI processor
driver.

config CPU_IDLE_GOV_MENU
- tristate "'menu' governor"
+ bool
depends on CPU_IDLE && NO_HZ
default y
- help
- This cpuidle governor evaluates all available states and
chooses the
- deepest state that meets all of the following constraints: BM
activity,
- expected time until next timer interrupt, and last break event
time
- delta. It is designed to minimize power consumption.
Currently
- dynticks is required.
-
-endif # CPU_IDLE

-endmenu
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied.
Hey, what a great idea:-)

thanks,
-Len