Skip to contentSkip to conversation

Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build

PATCH [email protected] 2 participants 2 messages Sep 13, 2007 – Sep 14, 2007 Device mapper

lore
Share & tools
lore
#0 lore raw

Due to commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 kernel build is broken if (CONFIG_COMPAT && ! CONFIG_BLOCK):

CC fs/compat_ioctl.o
In file included from include/linux/raid/md_k.h:19,

                 from include/linux/raid/md.h:54,
                 from fs/compat_ioctl.c:25:

include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:40: error: dereferencing pointer to incomplete type include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:48: error: dereferencing pointer to incomplete type include/linux/raid/../../../drivers/md/dm-bio-list.h:51: error: dereferencing pointer to incomplete type include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:64: error: dereferencing pointer to incomplete type include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_merge_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:78: error: dereferencing pointer to incomplete type include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:90: error: dereferencing pointer to incomplete type include/linux/raid/../../../drivers/md/dm-bio-list.h:94: error: dereferencing pointer to incomplete type make[1]: *** [fs/compat_ioctl.o] Error 1
make: *** [fs] Error 2

So either revert that commit or better apply the attached patch to fix it.

Regards,

Andreas

--
Fix kernel compilation if CONFIG_COMPAT is selected but CONFIG_BLOCK is not. This is needed due to commit

    02a5e0acb3cb85d80d0fe834e366d38a92bbaa22
---
 drivers/md/dm-bio-list.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/md/dm-bio-list.h +3 -0
index 16ee3b0..3f7b827 100644
@@ -9,6 +9,8 @@
 
 #include <linux/bio.h>
 
+#ifdef CONFIG_BLOCK
+
 struct bio_list {
 	struct bio *head;
 	struct bio *tail;
@@ -106,4 +108,5 @@ static inline struct bio *bio_list_get(struct bio_list *bl)
 	return bio;
 }
 
+#endif /* CONFIG_BLOCK */
 #endif
Signature · 1 line
1.5.3