xpad: fix Kconfig to avoid compile error
Subsystems (2)
PATCH 1/1 xpad: fix Kconfig to avoid compile error
With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:
...
LD .tmp_vmlinux1drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0xb3d6b): undefined reference to led_classdev_unregister' drivers/built-in.o: In function xpad_probe':
xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
...
To avoid this kernel configuration, do auto-select LEDS_CLASS for JOYSTCK_XPAD_LEDS.
--- drivers/input/joystick/Kconfig | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/input/joystick/Kconfig +3 -1
@@ -277,7 +277,9 @@ config JOYSTICK_XPAD_FF config JOYSTICK_XPAD_LEDS bool "LED Support for Xbox360 controller 'BigX' LED" - depends on LEDS_CLASS && JOYSTICK_XPAD + depends on JOYSTICK_XPAD + select NEW_LEDS + select LEDS_CLASS ---help--- This option enables support for the LED which surrounds the Big X on XBox 360 controller.
Signature · 1 line
1.5.3
Could somebody please correct the security issue on this server? I've been getting spam originating on it for almost a year.
The volume is becoming large enough that I'm considering blacklisting the server.
Dmitry Torokhov
maintainerQuoted 9 lines · Charles Chambers
Could somebody please correct the security issue on this server?
I've been getting spam originating on it for almost a year.
The volume is becoming large enough that I'm considering blacklisting the server.
Unsubscribing from the mailing lists you are not interested in is usually much easier.
Signature · 7 lines
Dmitry List-Owner: <mailto:[email protected]> List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:[email protected]?body=unsubscribe> List-Help: <mailto:[email protected]?body=help>
Dmitry Torokhov
maintainerHi Andreas,
Quoted 11 lines · Andreas Herrmann
With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:
...LD .tmp_vmlinux1
drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0xb3d6b): undefined reference toled_classdev_unregister' drivers/built-in.o: In functionxpad_probe':
xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
...
Quoted 3 lines
To avoid this kernel configuration, do auto-select
LEDS_CLASSforJOYSTCK_XPAD_LEDS.
I'd rather it depend on LEDS_CLASS (but properly). I believe I posted a patch yesterday.
Signature · 1 line
Dmitry
Quoted 6 lines · Dmitry Torokhov
Quoted 3 lines
To avoid this kernel configuration, do auto-select
LEDS_CLASSforJOYSTCK_XPAD_LEDS.I'd rather it depend on
LEDS_CLASS(but properly). I believe I posted a patch yesterday.
Didn't see this as I am not subscribed to one of the input or joystick mailing lists (and didn't find any archive for that lists either).
So today I have checked your input.git tree on git.kernel.org.
Your patch (commit be1945c47248fa9c0a7cf4a04c1f4c32928656d2) works fine if you rename LED_CLASS to LEDS_CLASS ...
So better fix that typo before your tree is pulled into Linus' tree. ;-)
Thanks and Regards,
Andreas
Dmitry Torokhov
maintainerQuoted 12 lines · Andreas Herrmann
Quoted 6 lines · Dmitry Torokhov
Quoted 3 lines
To avoid this kernel configuration, do auto-select
LEDS_CLASSforJOYSTCK_XPAD_LEDS.I'd rather it depend on
LEDS_CLASS(but properly). I believe I posted a patch yesterday.Didn't see this as I am not subscribed to one of the input or joystick mailing lists (and didn't find any archive for that lists either).
So today I have checked your input.git tree on git.kernel.org.
Quoted 6 lines
Your patch (commit
be1945c47248fa9c0a7cf4a04c1f4c32928656d2) works fine if you renameLED_CLASStoLEDS_CLASS...So better fix that typo before your tree is pulled into Linus' tree. ;-)
Oops, thank you ;)
Signature · 1 line
Dmitry