Skip to contentSkip to conversation

ocfs2: inconsequent NULL checking

DISCUSSION Adrian Bunk 1 participant 1 message Sep 18, 2007 OCFS2

lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following inconsequent NULL checking in fs/ocfs2/dlmglue.c:

<-- snip -->

...
int ocfs2_meta_lock_atime(struct inode *inode,
struct vfsmount *vfsmnt, int *level)
{
...

                if (ocfs2_should_update_atime(inode, vfsmnt))
                        ocfs2_update_inode_atime(inode, bh);
                if (bh)
                        brelse(bh);

...

<-- snip -->

Since commit c11e9fafb398411af7558fca913c2fa4a10b1f48 ocfs2_update_inode_atime() contains an unconditional dereference of "bh".

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed