Skip to contentSkip to conversation

Please pull 'p54' branch of wireless-2.6

DISCUSSION Applied John W. Linville 6 participants 7 messages Sep 19, 2007 4 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Jeff & Dave,

This patch adds the p54 driver for prism54 hardware using the "soft MAC" firmware. It includes modules for both PCI and USB drivers.

This driver has been in Fedora (both F7 and rawhide) for some time and has generally performed well. No doubt there are some problems with the code, but still I think it would be better to mainline the driver than to keep it out of stream.

Thanks,

John

---

The patch is available here:

	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/p54/0001-p54-add-mac80211-based-driver-for-prism54-softmac.patch

---

The following changes since commit 0d4cbb5e7f60b2f1a4d8b7f6ea4cc264262c7a01:
Linus Torvalds (1):

        Linux 2.6.23-rc6

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git p54

Michael Wu (1):
p54: add mac80211-based driver for prism54 softmac hardware

 MAINTAINERS                      |    8 +
 drivers/net/wireless/Kconfig     |   13 +
 drivers/net/wireless/Makefile    |    4 +
 drivers/net/wireless/net2280.h   |  452 +++++++++++++++++
 drivers/net/wireless/p54.h       |   80 +++
 drivers/net/wireless/p54common.c |  983 ++++++++++++++++++++++++++++++++++++++
 drivers/net/wireless/p54common.h |  329 +++++++++++++
 drivers/net/wireless/p54pci.c    |  689 ++++++++++++++++++++++++++
 drivers/net/wireless/p54pci.h    |  106 ++++
 drivers/net/wireless/p54usb.c    |  904 +++++++++++++++++++++++++++++++++++
 drivers/net/wireless/p54usb.h    |  133 +++++
 11 files changed, 3701 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/wireless/net2280.h
 create mode 100644 drivers/net/wireless/p54.h
 create mode 100644 drivers/net/wireless/p54common.c
 create mode 100644 drivers/net/wireless/p54common.h
 create mode 100644 drivers/net/wireless/p54pci.c
 create mode 100644 drivers/net/wireless/p54pci.h
 create mode 100644 drivers/net/wireless/p54usb.c
 create mode 100644 drivers/net/wireless/p54usb.h
Signature · 2 lines
John W. Linville
[email protected]
maintainer Applied
#1 lore raw

From: "John W. Linville" <[email protected]>
Date: Wed, 19 Sep 2007 15:55:27 -0400

Quoted 7 lines

This patch adds the p54 driver for prism54 hardware using the "soft MAC" firmware. It includes modules for both PCI and USB drivers.

This driver has been in Fedora (both F7 and rawhide) for some time and has generally performed well. No doubt there are some problems with the code, but still I think it would be better to mainline the driver than to keep it out of stream.

Merged to net-2.6.24, thanks John.

#3 lore raw
In reply to a message not in the archive
Quoted 10 lines · John W. Linville
 drivers/net/wireless/Kconfig     |   13 +
 drivers/net/wireless/Makefile    |    4 +
 drivers/net/wireless/net2280.h   |  452 +++++++++++++++++
 drivers/net/wireless/p54.h       |   80 +++
 drivers/net/wireless/p54common.c |  983 ++++++++++++++++++++++++++++++++++++++
 drivers/net/wireless/p54common.h |  329 +++++++++++++
 drivers/net/wireless/p54pci.c    |  689 ++++++++++++++++++++++++++
 drivers/net/wireless/p54pci.h    |  106 ++++
 drivers/net/wireless/p54usb.c    |  904 +++++++++++++++++++++++++++++++++++
 drivers/net/wireless/p54usb.h    |  133 +++++

PLease put it into a separate subdirectory, thanks.

Also net2280.h seems rather oddly named.

maintainer
#4 lore raw

From: Christoph Hellwig <[email protected]>
Date: Wed, 19 Sep 2007 22:04:05 +0100

Quoted 3 lines

PLease put it into a separate subdirectory, thanks.

Also net2280.h seems rather oddly named.

The next time I rebase I'll try to take care of this for both this driver and the iwlwifi stuff.

#6 lore raw
In reply to a message not in the archive
Quoted 9 lines · David Miller

From: Christoph Hellwig <[email protected]>
Date: Wed, 19 Sep 2007 22:04:05 +0100

Quoted 3 lines

PLease put it into a separate subdirectory, thanks.

Also net2280.h seems rather oddly named.

The next time I rebase I'll try to take care of this for both this driver and the iwlwifi stuff.

Fine by me, although I swear I remember complaints about adding separate directories for drivers...*shrug*...

John

Signature · 2 lines
John W. Linville
[email protected]
#8 lore raw
In reply to a message not in the archive
Quoted 4 lines · John W. Linville
Quoted 3 lines · David Miller

From: Christoph Hellwig <[email protected]>
Date: Wed, 19 Sep 2007 22:04:05 +0100

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

PLease put it into a separate subdirectory, thanks.

Also net2280.h seems rather oddly named.

The next time I rebase I'll try to take care of this for both this driver and the iwlwifi stuff.

Fine by me, although I swear I remember complaints about adding separate directories for drivers...*shrug*...

There were complaints about the nonsensical wireless/mac80211 directory.
But if there are enough files, a driver should definitely get its own
directory. Like life, it's a balance. If it's just one or two C files, a directory might be overkill. If it's more, it definitely warrants a sub-dir.

Jeff

#10 lore raw
In reply to a message not in the archive

From: Jeff Garzik <[email protected]>
Date: Wed, 19 Sep 2007 18:01:32 -0400

Quoted 5 lines

There were complaints about the nonsensical wireless/mac80211 directory. But if there are enough files, a driver should definitely get its own directory. Like life, it's a balance. If it's just one or two C files, a directory might be overkill. If it's more, it definitely warrants a sub-dir.

That's generally how I see things too.