2.6.23-rc8-mm1, -rc7-mm1 kill audio on HP nx6325
Hi,
This patch from Andi:
x86_64-mm-cpa-einval.patch
makes the hda_intel audio driver stop working on my HP nx6325.
The following line appears in dmesg (from 2.6.23-rc7-mm1:
ALSA /home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755: hd
a-intel: ioremap error
and the driver doesn't work afterwards.
Still, I'm not sure if the patch above is wrong or rather it exposes a problem in the driver.
Greetings,
Rafael
Quoted 10 lines · Rafael J. Wysocki
Hi,
This patch from Andi:
x86_64-mm-cpa-einval.patch
makes the
hda_intelaudio driver stop working on my HP nx6325.The following line appears in dmesg (from 2.6.23-rc7-mm1:
Quoted 7 lines
ALSA
/home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755: hd
a-intel: ioremap errorand the driver doesn't work afterwards.
Still, I'm not sure if the patch above is wrong or rather it exposes a problem in the driver.
The patch is correct. Instead of returning "Success" in the case of a failure of lookup_address, it now returns -EINVAL, which in turn makes the ioremap fail.
OTOH, the driver ioremap call looks straight forward. Can you apply the patch below and provide the resulting debug output please ?
Thanks,
tglx
arch/x86_64/mm/pageattr.c +3 -1
@@ -156,8 +156,10 @@ __change_page_attr(unsigned long addresspgprot_t ref_prot2; kpte =lookup_address (address); -if (!kpte) +if (!kpte) { +printk ("lookup failed for %lu\n" , address);return -EINVAL ; + } kpte_page =virt_to_page (((unsigned long )kpte) &PAGE_MASK );BUG_ON (PageCompound (kpte_page));
sound/pci/hda/hda_intel.c +2 -1
@@ -1752,7 +1752,8 @@ static int __devinit azx_create(struct s chip->addr =pci_resource_start (pci,0 ); chip->remap_addr =ioremap_nocache (chip->addr,pci_resource_len (pci,0 ));if (chip->remap_addr ==NULL ) { - snd_printk(KERN_ERR SFX "ioremap error\n"); + snd_printk(KERN_ERR SFX "ioremap error: %lu %lu\n", + chip->addr, pci_resource_len(pci, 0)); err = -ENXIO ; goto errout; }
Quoted 19 lines · Thomas Gleixner
Quoted 10 lines · Rafael J. Wysocki
Hi,
This patch from Andi:
x86_64-mm-cpa-einval.patch
makes the
hda_intelaudio driver stop working on my HP nx6325.The following line appears in dmesg (from 2.6.23-rc7-mm1:
Quoted 7 lines
ALSA
/home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755: hd
a-intel: ioremap errorand the driver doesn't work afterwards.
Still, I'm not sure if the patch above is wrong or rather it exposes a problem in the driver.
Quoted 6 lines
The patch is correct. Instead of returning "Success" in the case of a failure of
lookup_address, it now returns-EINVAL, which in turn makes the ioremap fail.OTOH, the driver ioremap call looks straight forward. Can you apply the patch below and provide the resulting debug output please ?
lookup failed for 18446604438082158592
[--snipped some USB messages--]
ALSA /home/rafael/src/mm/linux-2.6.23-rc8-mm1/sound/pci/hda/hda_intel.c:1756: hda-intel: ioremap error: 2349334528 16384
Greetings,
Rafael
Quoted 10 lines · Rafael J. Wysocki
Quoted 6 lines
The patch is correct. Instead of returning "Success" in the case of a failure of
lookup_address, it now returns-EINVAL, which in turn makes the ioremap fail.OTOH, the driver ioremap call looks straight forward. Can you apply the patch below and provide the resulting debug output please ?
lookup failed for 18446604438082158592
[--snipped some USB messages--]
ALSA/home/rafael/src/mm/linux-2.6.23-rc8-mm1/sound/pci/hda/hda_intel.c:1756: hda-intel: ioremap error: 2349334528 16384
Stupid me, hex formatting would have been easier to read :)
Lookup failed for 0xFFFF 8100 8C08 0000
ioremap: 0x0000 0000 8C08 0000 length 16384
It seems, that this patch only reveals some other wreckage. The code is called as part of ioremap, where it adjusts the caching attributes of the mapping, which was setup right before change_page_attr_address() is called.
tglx
Quoted 14 lines · Thomas Gleixner
Quoted 10 lines · Rafael J. Wysocki
Quoted 6 lines
The patch is correct. Instead of returning "Success" in the case of a failure of
lookup_address, it now returns-EINVAL, which in turn makes the ioremap fail.OTOH, the driver ioremap call looks straight forward. Can you apply the patch below and provide the resulting debug output please ?
lookup failed for 18446604438082158592
[--snipped some USB messages--]
ALSA/home/rafael/src/mm/linux-2.6.23-rc8-mm1/sound/pci/hda/hda_intel.c:1756: hda-intel: ioremap error: 2349334528 16384Stupid me, hex formatting would have been easier to read :)
Quoted 7 lines
Lookup failed for
0xFFFF8100 8C08 0000
ioremap:0x00000000 8C08 0000 length 16384It seems, that this patch only reveals some other wreckage. The code is called as part of ioremap, where it adjusts the caching attributes of the mapping, which was setup right before
change_page_attr_address()is called.
Hm, it looks like the first address is a kernel one and the second one is physical, so they apparently match, which means that the lookup shouldn't fail, if I understand this correctly.
Greetings,
Rafael
Quoted 9 lines · Rafael J. Wysocki
Quoted 9 lines
Quoted 3 lines
lookup failed for 18446604438082158592
[--snipped some USB messages--]
ALSA/home/rafael/src/mm/linux-2.6.23-rc8-mm1/sound/pci/hda/hda_intel.c:1756: hda-intel: ioremap error: 2349334528 16384Stupid me, hex formatting would have been easier to read :)
Lookup failed for
0xFFFF8100 8C08 0000
ioremap:0x00000000 8C08 0000 length 16384
Quoted 8 lines
Quoted 4 lines
It seems, that this patch only reveals some other wreckage. The code is called as part of ioremap, where it adjusts the caching attributes of the mapping, which was setup right before
change_page_attr_address()is called.Hm, it looks like the first address is a kernel one and the second one is physical, so they apparently match, which means that the lookup shouldn't fail, if I understand this correctly.
Yes, the lookup address is virtual and it should be the one, which was mapped right before the call to change_page_attr_address(). I'm looking into that right now.
tglx