Skip to contentSkip to conversation

More core work

PATCH In review Arnaldo Carvalho de Melo 2 participants 3 messages Sep 26, 2007

lore
Share & tools
lore
#0 lore raw

cover More core work

Hi David,

	Please consider pulling from:

	master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24

Best Regards,

- Arnaldo

#1 lore raw

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Wed, 26 Sep 2007 15:39:00 -0300

Quoted 5 lines

Hi David,

	Please consider pulling from:

	master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24

Pulled, but I'd like to make a small request.

Please remove the CONFIG_IP_DCCP_CCID3_DEBUG ifdef protection for the BUG_ON(hctx = NULL)

Either the assertion is valid, and therefore it should always be enabled, or it isn't.

If people want to turn off BUG checks, they turn off CONFIG_BUG.

Thanks!

#2 lore raw
In reply to Arnaldo Carvalho de Melo

Em Wed, Sep 26, 2007 at 02:08:37PM -0700, David Miller escreveu:

Quoted 11 lines

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Wed, 26 Sep 2007 15:39:00 -0300

Quoted 5 lines

Hi David,

	Please consider pulling from:

	master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24

Pulled, but I'd like to make a small request.

Quoted 7 lines

Please remove the CONFIG_IP_DCCP_CCID3_DEBUG ifdef protection for the BUG_ON(hctx = NULL)

Either the assertion is valid, and therefore it should always be enabled, or it isn't.

If people want to turn off BUG checks, they turn off CONFIG_BUG.

OK! I plead guilty for this one, Gerrit's patch didn't had that, will fix it in the next batch.

- Arnaldo