Skip to contentSkip to conversation

ide: enhance ide_setup_pci_noise()

PATCH NAK Bartlomiej Zolnierkiewicz 2 participants 2 messages Oct 1, 2007 – Oct 2, 2007 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 10/15 ide: enhance ide_setup_pci_noise()

* Print PCI device Vendor ID, Device ID and revision in ide_setup_pci_noise().

* Remove no longer needed PCI device revision printing from ide_setup_pci_controller().

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/setup-pci.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/ide/setup-pci.c +3 -5
Index: b/drivers/ide/setup-pci.c
===================================================================
@@ -227,8 +227,9 @@ static unsigned long ide_get_or_set_dma_
 
 void ide_setup_pci_noise(struct pci_dev *dev, const struct ide_port_info *d)
 {
-	printk(KERN_INFO "%s: IDE controller at PCI slot %s\n",
-			 d->name, pci_name(dev));
+	printk(KERN_INFO "%s: IDE controller (0x%04x:0x%04x rev 0x%02x) at "
+			 " PCI slot %s\n", d->name, dev->vendor, dev->device,
+			 dev->revision, pci_name(dev));
 }
 
 EXPORT_SYMBOL_GPL(ide_setup_pci_noise);

@@ -497,9 +498,6 @@ static int ide_setup_pci_controller(stru
 		printk(KERN_INFO "%s: device enabled (Linux)\n", d->name);
 	}
 
-	if (noisy)
-		printk(KERN_INFO "%s: chipset revision %d\n",
-				 d->name, dev->revision);
 out:
 	return ret;
 }