Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c
Subsystems (2)
PATCH 6/13 Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c
From: Micah Gruber <[email protected]>
This patch fixes an apparent potential null dereference bug where we dereference dev before a null check. This patch simply remvoes the can't-happen test for a null pointer.
Signed-off-by Micah Gruber <[email protected]>
Cc Grant Grundler <[email protected]>
Acked-by Jeff Garzik <[email protected]>
Acked-by Kyle McMartin <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/net/tulip/uli526x.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/net/tulip/uli526x.c renamed from drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt +0 -5
@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(intunsigned long ioaddr = dev->base_addr;unsigned long flags; -if (!dev) { -ULI526X_DBUG (1 ,"uli526x_interrupt() without DEVICE arg" ,0 ); -return IRQ_NONE ; - } -spin_lock_irqsave (&db->lock, flags);outl (0 , ioaddr +DCR7 );
_
Quoted 8 lines · On Tue, Oct 02, 2007 at 02:11:38PM -0700, [email protected] wrote:
From: Micah Gruber <[email protected]>
This patch fixes an apparent potential null dereference bug where we dereference dev before a null check. This patch simply remvoes the can't-happen test for a null pointer.
Signed-off-by Micah Gruber <[email protected]>Cc Grant Grundler <[email protected]>
Acked-by Grant Grundler <[email protected]>
thanks!
grant
Quoted 24 lines
Acked-by Jeff Garzik <[email protected]>Acked-by Kyle McMartin <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
drivers/net/tulip/uli526x.c | 5 ----- 1 file changed, 5 deletions(-)diff -puN
drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interruptdrivers/net/tulip/uli526x.cdrivers/net/tulip/uli526x.c renamed from drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt +0
-5@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(intunsigned long ioaddr = dev->base_addr;unsigned long flags; -if (!dev) { -ULI526X_DBUG (1 ,"uli526x_interrupt() without DEVICE arg" ,0 ); -return IRQ_NONE ; - } -spin_lock_irqsave (&db->lock, flags);outl (0 , ioaddr +DCR7 );_