Skip to contentSkip to conversation

ARM: OMAP: GPIO IRQSTATUS2 workaround applies to 2430

PATCH In review Kevin Hilman 2 participants 2 messages Oct 4, 2007 – Oct 9, 2007

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Kevin Hilman

author
#0 lore raw

PATCH 1/1 ARM: OMAP: GPIO IRQSTATUS2 workaround applies to 2430

The workaround to clear both sides of GPIO IRQ applies to 2430 as well as 2420. Use cpu_is_omap24xx() instead of cpu_is_omap2420()

Signed-off-by Kevin Hilman <[email protected]>
---
 arch/arm/plat-omap/gpio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/plat-omap/gpio.c +1 -1
Index: dev/arch/arm/plat-omap/gpio.c
===================================================================
@@ -709,7 +709,7 @@ static void _clear_gpio_irqbank(struct g
 
 	/* Workaround for clearing DSP GPIO interrupts to allow retention */
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
-	if (cpu_is_omap2420() || cpu_is_omap34xx())
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
 		__raw_writel(gpio_mask, bank->base + OMAP24XX_GPIO_IRQSTATUS2);
 #endif
 }

--

#1 lore raw
Quoted 14 lines · Kevin Hilman

The workaround to clear both sides of GPIO IRQ applies to 2430 as well as 2420. Use cpu_is_omap24xx() instead of cpu_is_omap2420()

Signed-off-by Kevin Hilman <[email protected]>
---
 arch/arm/plat-omap/gpio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: dev/arch/arm/plat-omap/gpio.c
===================================================================

arch/arm/plat-omap/gpio.c static void _clear_gpio_irqbank(struct g · line 715

Quoted 8 lines
arch/arm/plat-omap/gpio.c +1 -1
@@ -709,7 +709,7 @@ static void _clear_gpio_irqbank(struct g
 
 	/* Workaround for clearing DSP GPIO interrupts to allow retention */
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
-	if (cpu_is_omap2420() || cpu_is_omap34xx())
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
 		__raw_writel(gpio_mask, bank->base + OMAP24XX_GPIO_IRQSTATUS2);
 #endif
 }

Pushing today.

Tony