Skip to contentSkip to conversation

Rename is_cgroup_init()

PATCH In review [email protected] 2 participants 2 messages Oct 4, 2007 – Oct 5, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Rename is_cgroup_init()

From: Sukadev Bhattiprolu <[email protected]>
Subject: [PATCH] Rename is_cgroup_init()

is_container_init() was accidentally renamed to is_cgroup_init() when renaming "container" to "control group". This patch restores the original name.

---
 include/linux/sched.h |    4 ++--
 kernel/capability.c   |    2 +-
 kernel/pid.c          |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)
include/linux/sched.h +2 -2
Index: 2.6.23-rc8-mm2/include/linux/sched.h
===================================================================
@@ -1303,10 +1303,10 @@ static inline int is_global_init(struct 
 }
 
 /*
- * is_cgroup_init:
+ * is_container_init:
  * check whether in the task is init in its own pid namespace.
  */
-extern int is_cgroup_init(struct task_struct *tsk);
+extern int is_container_init(struct task_struct *tsk);
 
 extern struct pid *cad_pid;
 
kernel/capability.c +1 -1
Index: 2.6.23-rc8-mm2/kernel/capability.c
===================================================================
@@ -130,7 +130,7 @@ static inline int cap_set_all(kernel_cap
      int found = 0;
 
      do_each_thread(g, target) {
-             if (target == current || is_cgroup_init(target->group_leader))
+             if (target == current || is_container_init(target->group_leader))
                      continue;
              found = 1;
 	     if (security_capset_check(target, effective, inheritable,
kernel/pid.c +2 -2
Index: 2.6.23-rc8-mm2/kernel/pid.c
===================================================================
@@ -81,7 +81,7 @@ struct pid_namespace init_pid_ns = {
 };
 EXPORT_SYMBOL_GPL(init_pid_ns);
 
-int is_cgroup_init(struct task_struct *tsk)
+int is_container_init(struct task_struct *tsk)
 {
 	int ret = 0;
 	struct pid *pid;
@@ -94,7 +94,7 @@ int is_cgroup_init(struct task_struct *t
 
 	return ret;
 }
-EXPORT_SYMBOL(is_cgroup_init);
+EXPORT_SYMBOL(is_container_init);
 
 /*
  * Note: disable interrupts while the pidmap_lock is held as an
#1 lore raw

On Thu, 4 Oct 2007 09:15:59 -0700

Quoted 60 lines

From: Sukadev Bhattiprolu <[email protected]>
Subject: [PATCH] Rename is_cgroup_init()

is_container_init() was accidentally renamed to is_cgroup_init() when renaming "container" to "control group". This patch restores the original name.

---
 include/linux/sched.h |    4 ++--
 kernel/capability.c   |    2 +-
 kernel/pid.c          |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

Index: 2.6.23-rc8-mm2/include/linux/sched.h
===================================================================

include/linux/sched.h +2 -2
@@ -1303,10 +1303,10 @@ static inline int is_global_init(struct 
 }
 
 /*
- * is_cgroup_init:
+ * is_container_init:
  * check whether in the task is init in its own pid namespace.
  */
-extern int is_cgroup_init(struct task_struct *tsk);
+extern int is_container_init(struct task_struct *tsk);
 
 extern struct pid *cad_pid;
 

Index: 2.6.23-rc8-mm2/kernel/capability.c
===================================================================

kernel/capability.c +1 -1
@@ -130,7 +130,7 @@ static inline int cap_set_all(kernel_cap
      int found = 0;
 
      do_each_thread(g, target) {
-             if (target == current || is_cgroup_init(target->group_leader))
+             if (target == current || is_container_init(target->group_leader))
                      continue;
              found = 1;
 	     if (security_capset_check(target, effective, inheritable,

Index: 2.6.23-rc8-mm2/kernel/pid.c
===================================================================

kernel/pid.c +1 -1
@@ -81,7 +81,7 @@ struct pid_namespace init_pid_ns = {
 };
 EXPORT_SYMBOL_GPL(init_pid_ns);
 
-int is_cgroup_init(struct task_struct *tsk)
+int is_container_init(struct task_struct *tsk)
 {
 	int ret = 0;
 	struct pid *pid;

kernel/pid.c int is_cgroup_init(struct task_struct *t · line 100

Quoted 8 lines
kernel/pid.c +1 -1
@@ -94,7 +94,7 @@ int is_cgroup_init(struct task_struct *t
 
 	return ret;
 }
-EXPORT_SYMBOL(is_cgroup_init);
+EXPORT_SYMBOL(is_container_init);
 
 /*
  * Note: disable interrupts while the pidmap_lock is held as an

This patch is splattered across approximately seven different patches - ugly.

I just edited the diffs and changelogs in place and replaced all occurrences of is_cgroup_init with is_container_init