Skip to contentSkip to conversation

solved: 2.6.23 && fglrx && s2ram

PATCH Michael Leun 4 participants 7 messages Oct 11, 2007 – Oct 12, 2007

lore
Share & tools
lore
#0 lore raw

Hello,

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Renaming the config options for suspend/sleep broke fglrx power management.

firegl_public.h renamed from firegl_public.h.orig +1 -1
@@ -172,7 +172,7 @@
 #endif
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
-#if !defined(CONFIG_SMP) || defined(CONFIG_SUSPEND_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13) 
+#if !defined(CONFIG_SMP) || defined(CONFIG_PM_SLEEP_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13) 
 #define FIREGL_POWER_MANAGEMENT
 #endif
 #endif
Signature · 3 lines
MfG,

Michael Leun
#1 lore raw

Hi,

Quoted 8 lines · Michael Leun

Hello,

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Renaming the config options for suspend/sleep broke fglrx power management.

It looks like your patch is against the fglrx driver, isn't it?

firegl_public.h line 178

Quoted 13 lines
firegl_public.h renamed from firegl_public.h.orig +1 -1
@@ -172,7 +172,7 @@
 #endif
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
-#if !defined(CONFIG_SMP) || defined(CONFIG_SUSPEND_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13) 
+#if !defined(CONFIG_SMP) || defined(CONFIG_PM_SLEEP_SMP) // ACPI not working on older SMP kernel (prior to 2.6.13) 
 #define FIREGL_POWER_MANAGEMENT
 #endif
 #endif

Greetings,
Rafael

#2 lore raw
Quoted 5 lines · On Fri, 12 Oct 2007 01:31:17 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

Quoted 2 lines · Michael Leun

Hello,

Quoted 8 lines
Quoted 6 lines

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Renaming the config options for suspend/sleep broke fglrx power management.

It looks like your patch is against the fglrx driver, isn't it?

It is - I should have mentioned that, sorry.

Signature · 3 lines
MfG,

Michael Leun
#3 lore raw
Quoted 12 lines · Michael Leun
Quoted 9 lines · On Fri, 12 Oct 2007 01:31:17 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

Quoted 6 lines · Michael Leun

Hello,

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Renaming the config options for suspend/sleep broke fglrx power management.

It looks like your patch is against the fglrx driver, isn't it?

It is - I should have mentioned that, sorry.

This makes it 100% off-topic for linux-kernel - please send patches for illegal modules to the vendors of these modules and not here.

Quoted 3 lines

MfG,

Michael Leun

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 16 lines · Adrian Bunk
Quoted 15 lines · Michael Leun
Quoted 12 lines · On Fri, 12 Oct 2007 01:31:17 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

Quoted 8 lines · Michael Leun

Hello,

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Renaming the config options for suspend/sleep broke fglrx power management.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

It looks like your patch is against the fglrx driver, isn't it?

It is - I should have mentioned that, sorry.

This makes it 100% off-topic for linux-kernel - please send patches for illegal modules to the vendors of these modules and not here.

Well, the information that it got broken by itself is valuable, so thanks for it Michael, but the patch is certainly not interesting to us. :-)

Greetings,
Rafael

#5 lore raw
In reply to Adrian Bunk
Quoted 13 lines · Adrian Bunk
Quoted 12 lines · Michael Leun
Quoted 9 lines · On Fri, 12 Oct 2007 01:31:17 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

Quoted 6 lines · Michael Leun

Hello,

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines

Renaming the config options for suspend/sleep broke fglrx power management.

It looks like your patch is against the fglrx driver, isn't it?

It is - I should have mentioned that, sorry.

This makes it 100% off-topic for linux-kernel - please send patches for illegal modules to the vendors of these modules and not here.

Which would help the actual users of the module not one whit. Whereas putting the patch here helps the people who need it and allows multiple people to complain to the vendor.

If this module violates some law you should report it to the appropriate authorities rather than posting it here, otherwise you should probably should not use the term illegal casually.

Signature · 3 lines
Bill Davidsen <[email protected]>
  "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot
#6 lore raw
Quoted 16 lines · Bill Davidsen
Quoted 15 lines · Adrian Bunk
Quoted 14 lines · Michael Leun
Quoted 11 lines · On Fri, 12 Oct 2007 01:31:17 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

Quoted 8 lines · Michael Leun

Hello,

(please, don't blame me for using the binary only driver, I will happily switch to a open source one once it properly runs mplayer, e.g.).

Renaming the config options for suspend/sleep broke fglrx power management.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line

It looks like your patch is against the fglrx driver, isn't it?

It is - I should have mentioned that, sorry.

This makes it 100% off-topic for linux-kernel - please send patches for illegal modules to the vendors of these modules and not here.

Which would help the actual users of the module not one whit. Whereas putting the patch here helps the people who need it and allows multiple people to complain to the vendor.
...

The vendor has his own forums and support channels. That's what the term "off-topic" describes.

And what's worst is that people on this list might become tainted by seeing part of the fglrx source code.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed