Skip to contentSkip to conversation

drivers/block/cpqarray,cciss: kill unused var

PATCH In review Jeff Garzik 3 participants 3 messages Oct 13, 2007 – Oct 16, 2007 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/block/cpqarray,cciss: kill unused var

The recent bio work and subsequent fixups created unused variables.

---
 drivers/block/cciss.c    |    1 -
 drivers/block/cpqarray.c |    3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/block/cciss.c +0 -1
index 28d1457..27401d6 100644
@@ -1191,7 +1191,6 @@ static inline void complete_buffers(struct bio *bio, int status)
 {
 	while (bio) {
 		struct bio *xbh = bio->bi_next;
-		int nr_sectors = bio_sectors(bio);
 
 		bio->bi_next = NULL;
 		bio_endio(bio, status ? 0 : -EIO);
drivers/block/cpqarray.c +1 -2
index 3853c9a..568603d 100644
@@ -981,9 +981,8 @@ static void start_io(ctlr_info_t *h)
 static inline void complete_buffers(struct bio *bio, int ok)
 {
 	struct bio *xbh;
-	while(bio) {
-		int nr_sectors = bio_sectors(bio);
 
+	while (bio) {
 		xbh = bio->bi_next;
 		bio->bi_next = NULL;
 		
#1 lore raw
Quoted 7 lines · Jeff Garzik

The recent bio work and subsequent fixups created unused variables.

---
 drivers/block/cciss.c    |    1 -
 drivers/block/cpqarray.c |    3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

Thanks Jeff, applied.

Signature · 1 line
Jens Axboe
Acked-by on v1 1/1
#2 lore raw
In reply to Jeff Garzik
Quoted 9 lines

-----Original Message-----
From: Jeff Garzik [mailto:[email protected]]
Sent: Saturday, October 13, 2007 2:04 PM
To: Andrew Morton; Linus Torvalds
Cc: LKML; [email protected]; ISS StorageDev
Subject: [PATCH] drivers/block/cpqarray,cciss: kill unused var

Quoted 3 lines

The recent bio work and subsequent fixups created unused variables.

Quoted 32 lines
---
 drivers/block/cciss.c    |    1 -
 drivers/block/cpqarray.c |    3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/block/cciss.c +0 -1
index 28d1457..27401d6 100644
@@ -1191,7 +1191,6 @@ static inline void 
 complete_buffers(struct bio *bio, int status)  {
 	while (bio) {
 		struct bio *xbh = bio->bi_next;
-		int nr_sectors = bio_sectors(bio);
 
 		bio->bi_next = NULL;
 		bio_endio(bio, status ? 0 : -EIO);
(quoted diff) +0 -0

b/drivers/block/cpqarray.c index 3853c9a..568603d 100644

drivers/block/cpqarray.c +1 -2
@@ -981,9 +981,8 @@ static void start_io(ctlr_info_t *h)  
 static inline void complete_buffers(struct bio *bio, int ok)  {
 	struct bio *xbh;
-	while(bio) {
-		int nr_sectors = bio_sectors(bio);
 
+	while (bio) {
 		xbh = bio->bi_next;
 		bio->bi_next = NULL;