Skip to contentSkip to conversation

JFS: Bio cleanup: Replace missing return statements

PATCH In review Jeff Garzik 3 participants 3 messages Oct 13, 2007 – Oct 14, 2007 JFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 JFS: Bio cleanup: Replace missing return statements

From: Dave Kleikamp <[email protected]>

commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" statements, rather than changing them to null returns.

---
Dave sent this under a different cover, but just in case it was missed in the middle of the thread, I wanted to make sure it was not missed.

 fs/jfs/jfs_logmgr.c |    3 +++
 1 file changed, 3 insertions(+)
fs/jfs/jfs_logmgr.c +3 -0
index ccfd029..15a3974 100644
@@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
 
 		/* wakeup I/O initiator */
 		LCACHE_WAKEUP(&bp->l_ioevent);
+
+		return;
 	}
 
 	/*
@@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
 	if (bp->l_flag & lbmDIRECT) {
 		LCACHE_WAKEUP(&bp->l_ioevent);
 		LCACHE_UNLOCK(flags);
+		return;
 	}
 
 	tail = log->wqueue;
#1 lore raw
Quoted 5 lines · On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote:

From: Dave Kleikamp <[email protected]>

commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" statements, rather than changing them to null returns.

Is my git tree mucked up? It looks to me like it was commit e30408b2a99cb7b8bf529c7dc2328a19d71894cf that removed the return 0's.

Quoted 23 lines

---
Dave sent this under a different cover, but just in case it was missed in the middle of the thread, I wanted to make sure it was not missed.

 fs/jfs/jfs_logmgr.c |    3 +++
 1 file changed, 3 insertions(+)
fs/jfs/jfs_logmgr.c +2 -0
index ccfd029..15a3974 100644
@@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
 
 		/* wakeup I/O initiator */
 		LCACHE_WAKEUP(&bp->l_ioevent);
+
+		return;
 	}
 
 	/*

fs/jfs/jfs_logmgr.c static void lbmIODone(struct bio *bio, int error) · line 2266

Quoted 7 lines
fs/jfs/jfs_logmgr.c +1 -0
@@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
 	if (bp->l_flag & lbmDIRECT) {
 		LCACHE_WAKEUP(&bp->l_ioevent);
 		LCACHE_UNLOCK(flags);
+		return;
 	}
 
 	tail = log->wqueue;

---
~Randy

#2 lore raw
Quoted 10 lines · Randy Dunlap
Quoted 5 lines · On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote:

From: Dave Kleikamp <[email protected]>

commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" statements, rather than changing them to null returns.

Is my git tree mucked up? It looks to me like it was commit e30408b2a99cb7b8bf529c7dc2328a19d71894cf that removed the return 0's.

Yeah. It was that one. I cut and pasted the wrong one for the comment.

Thanks,
Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center