Skip to contentSkip to conversation

-git mips defconfig compile error

DISCUSSION Adrian Bunk 3 participants 4 messages Oct 14, 2007 – Oct 15, 2007 MIPS

lore
Share & tools
lore
#0 lore raw

Commit 05dc8c02bf40090e9ed23932b1980ead48eb8870 causes the following compile error with the mips defconfig:

<-- snip -->

...
CC drivers/video/logo/logo.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c: In function 'fb_find_logo':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'mips_machgroup' undeclared (first use in this function) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: (Each undeclared identifier is reported only once /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: for each function it appears in.) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'MACH_GROUP_SGI' undeclared (first use in this function) make[4]: *** [drivers/video/logo/logo.o] Error 1

<-- snip -->

It seems the drivers/net/jazzsonic.c and drivers/video/logo/logo.c parts that are part of the corresponding commit in the mips git tree got lost somewhere.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 14 lines · Adrian Bunk

Commit 05dc8c02bf40090e9ed23932b1980ead48eb8870 causes the following compile error with the mips defconfig:

<-- snip -->

...
CC drivers/video/logo/logo.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c: In function 'fb_find_logo':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'mips_machgroup' undeclared (first use in this function) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: (Each undeclared identifier is reported only once /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: for each function it appears in.) /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'MACH_GROUP_SGI' undeclared (first use in this function) make[4]: *** [drivers/video/logo/logo.o] Error 1

Quoted 5 lines

<-- snip -->

It seems the drivers/net/jazzsonic.c and drivers/video/logo/logo.c parts that are part of the corresponding commit in the mips git tree got lost somewhere.

The logo.c bit I've sent out a few weeks ago so I'm just waiting for that patch to resurface at the other end of the wormhole.

The jazzsonic breakage was caused by the not very well done "[NET]:
Introduce and use print_mac() and DECLARE_MAC_BUF()" patch aka 0795af5729b18218767fab27c44b1384f72dc9ad.

(No need to mail me about build failures of default configurations; there is an autobuilder building them regularly ...)

Ralf

#2 lore raw
Quoted 2 lines · Ralf Baechle

The logo.c bit I've sent out a few weeks ago so I'm just waiting for that patch to resurface at the other end of the wormhole.

Hmm, I would have waited for this to happen before committing the change
depending on it not to keep things known-broken then... That's what I do with my bits, e.g. I have an update to platform code waiting till sb1250-mac.c changes come over here.

Maciej

#3 lore raw
Quoted 7 lines · Maciej W. Rozycki
Quoted 2 lines

The logo.c bit I've sent out a few weeks ago so I'm just waiting for that patch to resurface at the other end of the wormhole.

Hmm, I would have waited for this to happen before committing the change
depending on it not to keep things known-broken then... That's what I do with my bits, e.g. I have an update to platform code waiting till sb1250-mac.c changes come over here.

Na, much more trivial. After a little looking into what went wrong I found that I meant to strip only the jazzsonic segment because of another jazzsonic patch from Fleedwood. But I stripped the logo.c bit as well.

Ralf