menuconfig: fail with clearer error if curses.h N/A
It would be nice if 'make menuconfig' could fail earlier or with a clearer error if curses.h is not available. The actual error is currently rather buried in a huge amount of indirect errors.
After installing libncurses-dev (Debian) everything was fine.
$ make menuconfig HOSTCC scripts/kconfig/lxdialog/checklist.o In file included from scripts/kconfig/lxdialog/checklist.c:24: scripts/kconfig/lxdialog/dialog.h:32:20: error: curses.h: No such file or directory In file included from scripts/kconfig/lxdialog/checklist.c:24: scripts/kconfig/lxdialog/dialog.h:97: error: expected specifier-qualifier-list before ‘chtype’ scripts/kconfig/lxdialog/dialog.h:187: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/dialog.h:194: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/dialog.h:196: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/dialog.h:197: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/dialog.h:198: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/dialog.h:199: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/dialog.h:201: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/checklist.c:31: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/checklist.c:59: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/checklist.c:95: error: expected ‘)’ before ‘*’ token scripts/kconfig/lxdialog/checklist.c: In function ‘dialog_checklist’: [another 30 or so lines with warnings/errors omitted]
Cheers,
FJP
Quoted 3 lines · Frans Pop
It would be nice if 'make menuconfig' could fail earlier or with a clearer error if
curses.his not available. The actual error is currently rather buried in a huge amount of indirect errors.
It worked some time ago but I did not bother to check it out when it broke.
With following patch it fails like this:
$ make menuconfig *** Unable to find the ncurses libraries *** or the required header files. *** make menuconfig require the ncurses libraries *** *** Install ncurses (ncurses-devel) and try again *** make[1]: *** [scripts/kconfig/dochecklxdialog] Error 1 make: *** [menuconfig] Error 2
This is much better.
Sam
scripts/kconfig/Makefile +8 -6
@@ -93,12 +93,6 @@ HOST_LOADLIBES = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) HOST_EXTRACFLAGS += -DLOCALE -PHONY += $(obj)/dochecklxdialog -$(obj)/dochecklxdialog: - $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_LOADLIBES) - -always := dochecklxdialog - # =========================================================================== # Shared Makefile for the various kconfig executables:
@@ -145,6 +139,14 @@ clean-files := lkc_defs.h qconf.moc .tmp_qtcheck \ .tmp_gtkcheck zconf.tab.c lex.zconf.c zconf.hash.c clean-files += mconf qconf gconf +# Check that we have the required ncurses stuff installed for lxdialog (menuconfig) +PHONY += $(obj)/dochecklxdialog +$(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog +$(obj)/dochecklxdialog: + $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOST_LOADLIBES) + +always := dochecklxdialog + # Add environment specific flags HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCC) $(HOSTCFLAGS))
scripts/kconfig/lxdialog/check-lxdialog.sh +3 -2
@@ -36,9 +36,10 @@ trap "rm -f $tmp" 0 1 2 3 15 # Check if we can link to ncurses check() { - echo "main() {}" | $cc -xc - -o $tmp 2> /dev/null + echo " \#include CURSES_LOC main() {}" | $cc -xc - -o $tmp 2> /dev/null if [ $? != 0 ]; then - echo " *** Unable to find the ncurses libraries." 1>&2 + echo " *** Unable to find the ncurses libraries" 1>&2 + echo " *** or the required header files." 1>&2 echo " *** make menuconfig require the ncurses libraries" 1>&2 echo " *** " 1>&2 echo " *** Install ncurses (ncurses-devel) and try again" 1>&2
Quoted 1 line · Sam Ravnborg
This is much better.
Thanks!
A few minor corrections maybe (nitpicks really).
Quoted 2 lines
*** Unable to find the ncurses libraries
*** or the required header files.
That first line is strangely short like this.
Move "or the" to the first line?
Quoted 1 line
*** make menuconfig require the ncurses libraries
At least s/require/requires/ and probably add a period at end of the line. I also suggest adding quotes around make menuconfig:
*** 'make menuconfig' requires the ncurses libraries.
Quoted 2 lines
***
*** Install ncurses (ncurses-devel) and try again
Again add a period at end of the line.
Cheers,
FJP
Quoted 6 lines · Frans Pop
Quoted 1 line · Sam Ravnborg
This is much better.
Thanks!
A few minor corrections maybe (nitpicks really).
Thanks - updated patch below.
Sam
Quoted 1 line
From
c00c91abddc0903e7b4bc818cfbaf401119ca676Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <[email protected]>
Date: Sun, 9 Dec 2007 20:11:15 +0100
Subject: [PATCH] kconfig: if ncurses-devel is missing then say so
With this patch when ncurses-devel (or whatever it is named) is missing trying to run menuconfig will result in this:
$ make menuconfig HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/kxgettext.o *** Unable to find the ncurses libraries or the *** required header files. *** 'make menuconfig' requires the ncurses libraries. *** *** Install ncurses (ncurses-devel) and try again. *** make[1]: *** [scripts/kconfig/dochecklxdialog] Error 1 make: *** [menuconfig] Error 2
Much better than before where we just listed some build errors. The other *config targets will work indepenednt on ncurses being present or not.
Includes improvements suggested by: Frans Pop <[email protected]>
--- scripts/kconfig/Makefile | 14 ++++++++------ scripts/kconfig/lxdialog/check-lxdialog.sh | 16 +++++++++------- 2 files changed, 17 insertions(+), 13 deletions(-)
scripts/kconfig/Makefile +8 -6
@@ -93,12 +93,6 @@ HOST_LOADLIBES = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) HOST_EXTRACFLAGS += -DLOCALE -PHONY += $(obj)/dochecklxdialog -$(obj)/dochecklxdialog: - $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_LOADLIBES) - -always := dochecklxdialog - # =========================================================================== # Shared Makefile for the various kconfig executables:
@@ -145,6 +139,14 @@ clean-files := lkc_defs.h qconf.moc .tmp_qtcheck \ .tmp_gtkcheck zconf.tab.c lex.zconf.c zconf.hash.c clean-files += mconf qconf gconf +# Check that we have the required ncurses stuff installed for lxdialog (menuconfig) +PHONY += $(obj)/dochecklxdialog +$(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog +$(obj)/dochecklxdialog: + $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOST_LOADLIBES) + +always := dochecklxdialog + # Add environment specific flags HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCC) $(HOSTCFLAGS))
scripts/kconfig/lxdialog/check-lxdialog.sh +9 -7
@@ -36,14 +36,16 @@ trap "rm -f $tmp" 0 1 2 3 15 # Check if we can link to ncurses check() { - echo "main() {}" | $cc -xc - -o $tmp 2> /dev/null + echo -e " #include CURSES_LOC \n main() {}" | + $cc -xc - -o $tmp 2> /dev/null if [ $? != 0 ]; then - echo " *** Unable to find the ncurses libraries." 1>&2 - echo " *** make menuconfig require the ncurses libraries" 1>&2 - echo " *** " 1>&2 - echo " *** Install ncurses (ncurses-devel) and try again" 1>&2 - echo " *** " 1>&2 - exit 1 + echo " *** Unable to find the ncurses libraries or the" 1>&2 + echo " *** required header files." 1>&2 + echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2 + echo " *** " 1>&2 + echo " *** Install ncurses (ncurses-devel) and try again." 1>&2 + echo " *** " 1>&2 + exit 1 fi }
Signature · 1 line
1.5.3.4