Skip to contentSkip to conversation

PCMCIA driver resource allocation

PATCH Bjorn Helgaas 3 participants 5 messages Oct 19, 2007 – Oct 22, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Question 1: Does the linux-pcmcia list still exist? It's in MAINTAINERS:

PCMCIA SUBSYSTEM

  P:      Linux PCMCIA Team
  L:      [email protected]
  L:      http://lists.infradead.org/mailman/listinfo/linux-pcmcia
  T:      git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
  S:      Maintained

but the archive: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
seems dead.

Question 2: Documentation/pcmcia/driver-changes.txt says drivers should now claim their own resources:

* Resource management. (as of 2.6.8)
Although the PCMCIA subsystem will allocate resources for cards, it no longer marks these resources busy. This means that driver authors are now responsible for claiming your resources as per other drivers in Linux.

But I don't see any drivers that do that. It looks like there should be a bunch of changes like the one below. Is there a reason these changes didn't happen, other than just lack of interest?

Bjorn

drivers/net/wireless/orinoco.h +1 -0
Index: work3/drivers/net/wireless/orinoco.h
===================================================================
@@ -57,6 +57,7 @@
 	struct iw_statistics wstats;
 
 	/* Hardware control variables */
+	struct resource *io_resource;
 	hermes_t hw;
 	u16 txfid;
 
drivers/net/wireless/orinoco_cs.c +8 -0
Index: work3/drivers/net/wireless/orinoco_cs.c
===================================================================
@@ -296,6 +296,10 @@
 	/* We initialize the hermes structure before completing PCMCIA
 	 * configuration just in case the interrupt handler gets
 	 * called. */
+	priv->io_resource = request_region(link->io.BasePort1,
+					   link->io.NumPorts1, DRIVER_NAME);
+	if (!priv->io_resource)
+		goto cs_failed;
 	mem = ioport_map(link->io.BasePort1, link->io.NumPorts1);
 	if (!mem)
 		goto cs_failed;
@@ -366,6 +370,10 @@
 	pcmcia_disable_device(link);
 	if (priv->hw.iobase)
 		ioport_unmap(priv->hw.iobase);
+	if (priv->io_resource) {
+		release_resource(priv->io_resource);
+		priv->io_resource = NULL;
+	}
 }				/* orinoco_cs_release */
 
 static int orinoco_cs_suspend(struct pcmcia_device *link)
#1 lore raw
Quoted 11 lines · Bjorn Helgaas

Question 1: Does the linux-pcmcia list still exist? It's in MAINTAINERS:

PCMCIA SUBSYSTEM

  P:      Linux PCMCIA Team
  L:      [email protected]
  L:      http://lists.infradead.org/mailman/listinfo/linux-pcmcia
  T:      git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
  S:      Maintained

but the archive: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
seems dead.

The list is still around, but Dominik seems to have vanished.

Quoted 9 lines

Question 2: Documentation/pcmcia/driver-changes.txt says drivers should now claim their own resources:

* Resource management. (as of 2.6.8)
Although the PCMCIA subsystem will allocate resources for cards, it no longer marks these resources busy. This means that driver authors are now responsible for claiming your resources as per other drivers in Linux.

Quoted 3 lines

But I don't see any drivers that do that. It looks like there should be a bunch of changes like the one below. Is there a reason these changes didn't happen, other than just lack of interest?

That's from around the time that I handed PCMCIA over to Dominik, and was a to-do item. I had some drivers converted over - mainly the few that I was using, those being serial and pcnet_cs (serial is converted over but the patch I had for pcnet_cs is below.)

However, in spite of me pointing Dominik at my remaining patch sets several times, as far as I could tell they got ignored. So essentially I all lost interest in helping out with PCMCIA.

Quoted 16 lines

Index: work3/drivers/net/wireless/orinoco_cs.c
===================================================================

drivers/net/wireless/orinoco_cs.c +4 -0
@@ -296,6 +296,10 @@
 	/* We initialize the hermes structure before completing PCMCIA
 	 * configuration just in case the interrupt handler gets
 	 * called. */
+	priv->io_resource = request_region(link->io.BasePort1,
+					   link->io.NumPorts1, DRIVER_NAME);
+	if (!priv->io_resource)
+		goto cs_failed;
 	mem = ioport_map(link->io.BasePort1, link->io.NumPorts1);
 	if (!mem)
 		goto cs_failed;

drivers/net/wireless/orinoco_cs.c line 375

Quoted 6 lines
drivers/net/wireless/orinoco_cs.c +3 -0
@@ -366,6 +370,10 @@
 	pcmcia_disable_device(link);
 	if (priv->hw.iobase)
 		ioport_unmap(priv->hw.iobase);
+	if (priv->io_resource) {
+		release_resource(priv->io_resource);
+		priv->io_resource = NULL;

Wrong function. release_resource() doesn't pair with request_region(). request_region() allocates memory for the struct resource. release_resource() merely removes the struct resource from the tree. release_region() on the other hand removes the struct resource and frees it.

---

Convert pcnet_cs and serial_cs to request their IO regions, thereby marking them busy. These are only two of many drivers which need this update.

drivers/net/pcmcia/pcnet_cs.c +10 -0
diff -u -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' ref/drivers/net/pcmcia/pcnet_cs.c linux/drivers/net/pcmcia/pcnet_cs.c
@@ -687,8 +687,15 @@
     dev->poll_controller = ei_poll;
 #endif
 
+    if (!request_region(dev->base_addr, link->io.NumPorts1, "pcnet_cs")) {
+	printk(KERN_NOTICE "pcnet_cs: request_region() failed\n");
+	link->dev = NULL;
+	goto failed;
+    }
+
     if (register_netdev(dev) != 0) {
 	printk(KERN_NOTICE "pcnet_cs: register_netdev() failed\n");
+	release_region(dev->base_addr, link->io.NumPorts1);
 	link->dev = NULL;
 	goto failed;
     }
@@ -736,6 +743,9 @@
 
     DEBUG(0, "pcnet_release(0x%p)\n", link);
 
+    if (link->dev)
+	release_region(link->io.BasePort1, link->io.NumPorts1);
+
     if (info->flags & USE_SHMEM) {
 	iounmap(info->base);
 	pcmcia_release_window(link->win);
Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#2 lore raw

On Fri, 19 Oct 2007 23:40:22 +0100
Russell King <[email protected]> wrote:

Ive been meaning to talk to dominik about some hp6xx pcmcia issues Im having, but seem to be quite hard to get in touch with him or the linux-pcmcia list.

Quoted 10 lines · Bjorn Helgaas
Quoted 9 lines

Question 1: Does the linux-pcmcia list still exist? It's in MAINTAINERS:

PCMCIA SUBSYSTEM

  P:      Linux PCMCIA Team
  L:      [email protected]
  L:      http://lists.infradead.org/mailman/listinfo/linux-pcmcia
  T:      git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
  S:      Maintained
Quoted 4 lines
Quoted 2 lines

but the archive: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
seems dead.

The list is still around, but Dominik seems to have vanished.

Ive tried to subscribbe to the list, but with no luck.

Quoted 99 lines
Quoted 10 lines

Question 2: Documentation/pcmcia/driver-changes.txt says drivers should now claim their own resources:

* Resource management. (as of 2.6.8)
Although the PCMCIA subsystem will allocate resources for cards, it no longer marks these resources busy. This means that driver authors are now responsible for claiming your resources as per other drivers in Linux.

Quoted 3 lines

But I don't see any drivers that do that. It looks like there should be a bunch of changes like the one below. Is there a reason these changes didn't happen, other than just lack of interest?

That's from around the time that I handed PCMCIA over to Dominik, and was a to-do item. I had some drivers converted over - mainly the few that I was using, those being serial and pcnet_cs (serial is converted over but the patch I had for pcnet_cs is below.)

However, in spite of me pointing Dominik at my remaining patch sets several times, as far as I could tell they got ignored. So essentially I all lost interest in helping out with PCMCIA.

Quoted 16 lines

Index: work3/drivers/net/wireless/orinoco_cs.c
===================================================================

drivers/net/wireless/orinoco_cs.c +4 -0
@@ -296,6 +296,10 @@
 	/* We initialize the hermes structure before completing PCMCIA
 	 * configuration just in case the interrupt handler gets
 	 * called. */
+	priv->io_resource = request_region(link->io.BasePort1,
+					   link->io.NumPorts1, DRIVER_NAME);
+	if (!priv->io_resource)
+		goto cs_failed;
 	mem = ioport_map(link->io.BasePort1, link->io.NumPorts1);
 	if (!mem)
 		goto cs_failed;

drivers/net/wireless/orinoco_cs.c line 375

Quoted 6 lines
drivers/net/wireless/orinoco_cs.c +3 -0
@@ -366,6 +370,10 @@
 	pcmcia_disable_device(link);
 	if (priv->hw.iobase)
 		ioport_unmap(priv->hw.iobase);
+	if (priv->io_resource) {
+		release_resource(priv->io_resource);
+		priv->io_resource = NULL;

Wrong function. release_resource() doesn't pair with request_region(). request_region() allocates memory for the struct resource. release_resource() merely removes the struct resource from the tree. release_region() on the other hand removes the struct resource and frees it.

---

Convert pcnet_cs and serial_cs to request their IO regions, thereby marking them busy. These are only two of many drivers which need this update.

diff -u -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' ref/drivers/net/pcmcia/pcnet_cs.c linux/drivers/net/pcmcia/pcnet_cs.c

drivers/net/pcmcia/pcnet_cs.c +10 -0
@@ -687,8 +687,15 @@
     dev->poll_controller = ei_poll;
 #endif
 
+    if (!request_region(dev->base_addr, link->io.NumPorts1, "pcnet_cs")) {
+	printk(KERN_NOTICE "pcnet_cs: request_region() failed\n");
+	link->dev = NULL;
+	goto failed;
+    }
+
     if (register_netdev(dev) != 0) {
 	printk(KERN_NOTICE "pcnet_cs: register_netdev() failed\n");
+	release_region(dev->base_addr, link->io.NumPorts1);
 	link->dev = NULL;
 	goto failed;
     }
@@ -736,6 +743,9 @@
 
     DEBUG(0, "pcnet_release(0x%p)\n", link);
 
+    if (link->dev)
+	release_region(link->io.BasePort1, link->io.NumPorts1);
+
     if (info->flags & USE_SHMEM) {
 	iounmap(info->base);
 	pcmcia_release_window(link->win);
Signature · 10 lines
-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Signature · 1 line
Kristoffer Ericson <[email protected]>
#3 lore raw
Quoted 4 lines · Kristoffer Ericson
Quoted 1 line · On Fri, 19 Oct 2007 23:40:22 +0100 Russell King <[email protected]>…

The list is still around, but Dominik seems to have vanished.

Ive tried to subscribbe to the list, but with no luck.

You might want to talk to David Woodhouse about that - he runs the mailing lists on lists.infradead.org.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#4 lore raw
In reply to Russell King
Quoted 14 lines · Russell King
Quoted 12 lines · Bjorn Helgaas
(quoted diff) +5 -0
+	priv->io_resource = request_region(link->io.BasePort1,
+					   link->io.NumPorts1, DRIVER_NAME);
+	if (!priv->io_resource)
+		goto cs_failed;
 	mem = ioport_map(link->io.BasePort1, link->io.NumPorts1);
 	if (!mem)
 		goto cs_failed;
@@ -366,6 +370,10 @@
 	pcmcia_disable_device(link);
 	if (priv->hw.iobase)
 		ioport_unmap(priv->hw.iobase);
+	if (priv->io_resource) {
Quoted 8 lines

Review line 375

Quoted 2 lines
(quoted diff) +2 -0
+		release_resource(priv->io_resource);
+		priv->io_resource = NULL;

Wrong function. release_resource() doesn't pair with request_region(). request_region() allocates memory for the struct resource. release_resource() merely removes the struct resource from the tree. release_region() on the other hand removes the struct resource and frees it.

Oh, thanks! I didn't notice that difference between release_region() and release_resource(). I'll fix the patch.

Bjorn