Skip to contentSkip to conversation

mark irqbalance not-recommended

PATCH Pavel Machek 4 participants 4 messages Oct 23, 2007

lore
Share & tools
lore
#0 lore raw

Mark CONFIG_IRQBALANCE as not recommended any more. It eats too much power, and better solutions are available in userspace.

---
commit 2665f7971b5b97830b028308553a78a95c131988
tree e1782cceebfb5900373469c0043d113de88f861f
parent f5085f6ea1c5771708c44a4a42ee217e760ff4a0
author Pavel <[email protected]> Tue, 23 Oct 2007 13:56:15 +0200 committer Pavel <[email protected]> Tue, 23 Oct 2007 13:56:15 +0200

 arch/i386/Kconfig |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
arch/i386/Kconfig +6 -3
index eba2d88..10f3c38 100644
@@ -779,10 +779,13 @@ config EFI
 config IRQBALANCE
  	bool "Enable kernel irq balancing"
 	depends on SMP && X86_IO_APIC
-	default y
+	default n
 	help
- 	  The default yes will allow the kernel to do irq load balancing.
-	  Saying no will keep the kernel from doing irq load balancing.
+ 	  Saying yes will allow the kernel to do irq load balancing;
+	  but it generates too many CPU wakeups, eating power, and
+	  is better done in userspace.
+
+	  Say N.
 
 # turning this on wastes a bunch of space.
 # Summit needs it only when NUMA is on
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 3 lines · Pavel Machek

Mark CONFIG_IRQBALANCE as not recommended any more. It eats too much power, and better solutions are available in userspace.

What about additionally a printk() during init and a feature-removal-schedule.txt entry scheduling removal one year from now?

Quoted 17 lines

---
commit 2665f7971b5b97830b028308553a78a95c131988
tree e1782cceebfb5900373469c0043d113de88f861f
parent f5085f6ea1c5771708c44a4a42ee217e760ff4a0
author Pavel <[email protected]> Tue, 23 Oct 2007 13:56:15 +0200 committer Pavel <[email protected]> Tue, 23 Oct 2007 13:56:15 +0200

 arch/i386/Kconfig |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
arch/i386/Kconfig +0 -0
index eba2d88..10f3c38 100644

arch/i386/Kconfig config EFI · line 780

Quoted 2 lines
arch/i386/Kconfig +0 -0
@@ -779,10 +779,13 @@ config EFI
 config IRQBALANCE
  	bool "Enable kernel irq balancing"

If you want people to notice it's deprecated you should add a " (DEPRECATED)" to the kconfig prompt.

arch/i386/Kconfig config EFI · line 782

Quoted 3 lines
arch/i386/Kconfig +1 -1
 	depends on SMP && X86_IO_APIC
-	default y
+	default n

Please drop the "default n", it has no effect.

arch/i386/Kconfig config EFI · line 791

Quoted 11 lines
arch/i386/Kconfig +5 -2
 	help
- 	  The default yes will allow the kernel to do irq load balancing.
-	  Saying no will keep the kernel from doing irq load balancing.
+ 	  Saying yes will allow the kernel to do irq load balancing;
+	  but it generates too many CPU wakeups, eating power, and
+	  is better done in userspace.
+
+	  Say N.
 
 # turning this on wastes a bunch of space.
 # Summit needs it only when NUMA is on

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed