Skip to contentSkip to conversation

make tcp_match_skb_to_sack() static

PATCH In review Adrian Bunk 3 participants 3 messages Oct 24, 2007 – Oct 26, 2007

Subsystems (3)
Networking Network drivers TCP
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 make tcp_match_skb_to_sack() static

tcp_match_skb_to_sack() can become static.

Signed-off-by Adrian Bunk <[email protected]>

---
b734b439219a6251b7deb65dad2307f9c891f680

net/ipv4/tcp_input.c +2 -2
index 9288220..603400d 100644
@@ -1204,8 +1204,8 @@ static int tcp_check_dsack(struct tcp_sock *tp, struct sk_buff *ack_skb,
  * which may fail and creates some hassle (caller must handle error case
  * returns).
  */
-int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
-			  u32 start_seq, u32 end_seq)
+static int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
+				 u32 start_seq, u32 end_seq)
 {
 	int in_sack, err;
 	unsigned int pkt_len;
#1 lore raw
Quoted 4 lines · Adrian Bunk

tcp_match_skb_to_sack() can become static.

Signed-off-by Adrian Bunk <[email protected]>

[...snip...]

Thanks, I should have noticed that right from the beginning...

Added DaveM to recipients.

Signature · 1 line
 i.
maintainer
#2 lore raw

From: "Ilpo_Järvinen" <[email protected]>
Date: Thu, 25 Oct 2007 00:39:23 +0300 (EEST)

Quoted 9 lines · Adrian Bunk
Quoted 5 lines

tcp_match_skb_to_sack() can become static.

Signed-off-by Adrian Bunk <[email protected]>

[...snip...]

Thanks, I should have noticed that right from the beginning...

Yep, applied, thanks!