gfs2_fh_to_parent() array overflow
The Coverity checker spotted the following array overflow caused by commit 34c0d154243dd913c5690ae6ceb9557017429b9c:
include/linux/exportfs.h contains:
<-- snip -->
...
struct fid {
...
__u32 raw[6];
};
};<-- snip -->
fs/gfs2/ops_export.c contains:
<-- snip -->
...
static struct dentry *gfs2_fh_to_parent(struct super_block *sb, struct fid *fid,
int fh_len, int fh_type)
{
struct gfs2_inum_host parent;
__be32 *fh = (__force __be32 *)fid->raw; <------------
switch (fh_type) {
case GFS2_LARGE_FH_SIZE:
case GFS2_OLD_FH_SIZE:
parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32;
parent.no_formal_ino |= be32_to_cpu(fh[5]);
parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32;
^^^^^
parent.no_addr |= be32_to_cpu(fh[7]);... ^^^^^
<-- snip -->
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 2 lines · Adrian Bunk
The Coverity checker spotted the following array overflow caused by commit
34c0d154243dd913c5690ae6ceb9557017429b9c:
The line is a left-over from times when gfs stored the mode of the inode in the file handle. It can simply be deleted. Steve, do you want a patch for that or could you commit that one-liner directly?
Quoted 19 lines
fs/gfs2/ops_export.ccontains:<-- snip -->
...
static struct dentry *gfs2_fh_to_parent(structsuper_block*sb, struct fid *fid,
intfh_len, intfh_type){ struct gfs2_inum_host parent; __be32 *fh = (__force __be32 *)fid->raw; <------------ switch (fh_type) { case GFS2_LARGE_FH_SIZE: case GFS2_OLD_FH_SIZE: parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32; parent.no_formal_ino |= be32_to_cpu(fh[5]); parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32; ^^^^^ parent.no_addr |= be32_to_cpu(fh[7]);
Quoted 14 lines
... ^^^^^
<-- snip -->
cu
AdrianSignature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
---end quoted text---
Hi,
Quoted 8 lines · Christoph Hellwig
Quoted 2 lines · Adrian Bunk
The Coverity checker spotted the following array overflow caused by commit
34c0d154243dd913c5690ae6ceb9557017429b9c:The line is a left-over from times when gfs stored the mode of the inode in the file handle. It can simply be deleted. Steve, do you want a patch for that or could you commit that one-liner directly?
I'm just back from holiday this morning and this is looking a bit more complicated than that... give me a day or two and I'll try and come up with a solution,
Steve.
Quoted 34 lines
Quoted 19 lines
fs/gfs2/ops_export.ccontains:<-- snip -->
...
static struct dentry *gfs2_fh_to_parent(structsuper_block*sb, struct fid *fid,
intfh_len, intfh_type){ struct gfs2_inum_host parent; __be32 *fh = (__force __be32 *)fid->raw; <------------ switch (fh_type) { case GFS2_LARGE_FH_SIZE: case GFS2_OLD_FH_SIZE: parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32; parent.no_formal_ino |= be32_to_cpu(fh[5]); parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32; ^^^^^ parent.no_addr |= be32_to_cpu(fh[7]);Quoted 14 lines
... ^^^^^
<-- snip -->
cu
AdrianSignature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed---end quoted text---
Quoted 7 lines · Steven Whitehouse
Hi,
Quoted 4 lines · Christoph Hellwig
Quoted 2 lines · Adrian Bunk
The Coverity checker spotted the following array overflow caused by commit
34c0d154243dd913c5690ae6ceb9557017429b9c:
Quoted 8 lines
Quoted 4 lines
The line is a left-over from times when gfs stored the mode of the inode in the file handle. It can simply be deleted. Steve, do you want a patch for that or could you commit that one-liner directly?
I'm just back from holiday this morning and this is looking a bit more complicated than that... give me a day or two and I'll try and come up with a solution,
This issue is still present in 2.6.25-rc1.
Quoted 29 lines
Steve.
Quoted 27 lines
Quoted 27 lines
fs/gfs2/ops_export.ccontains:<-- snip -->
...
static struct dentry *gfs2_fh_to_parent(structsuper_block*sb, struct fid *fid,
intfh_len, intfh_type){ struct gfs2_inum_host parent; __be32 *fh = (__force __be32 *)fid->raw; <------------ switch (fh_type) { case GFS2_LARGE_FH_SIZE: case GFS2_OLD_FH_SIZE: parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32; parent.no_formal_ino |= be32_to_cpu(fh[5]); parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32; ^^^^^ parent.no_addr |= be32_to_cpu(fh[7]);... ^^^^^
<-- snip -->
cu
Adrian
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedHi,
Quoted 13 lines · Adrian Bunk
Quoted 12 lines · Steven Whitehouse
Hi,
Quoted 8 lines · Christoph Hellwig
Quoted 2 lines · Adrian Bunk
The Coverity checker spotted the following array overflow caused by commit
34c0d154243dd913c5690ae6ceb9557017429b9c:The line is a left-over from times when gfs stored the mode of the inode in the file handle. It can simply be deleted. Steve, do you want a patch for that or could you commit that one-liner directly?
Quoted 6 lines
Quoted 3 lines
I'm just back from holiday this morning and this is looking a bit more complicated than that... give me a day or two and I'll try and come up with a solution,
This issue is still present in 2.6.25-rc1.
Yes, it seems to have slipped off my list somehow... I've opened a bz (#432775 at bugzilla.redhat.com) to ensure that it doesn't get missed again,
Steve.