Skip to contentSkip to conversation

CRIS architecture: Correct compile errors

PATCH In review Jesper Nilsson 2 participants 4 messages Oct 30, 2007 – Oct 31, 2007

lore
Share & tools
lore

Jesper Nilsson

author
#0 lore raw

PATCH 1/16 CRIS architecture: Correct compile errors

Remove include of asm/bitops.h, not needed here, corrects compilation error (__le64 undefined).

Signed-off-by Jesper Nilsson <[email protected]>
---
 posix_types.h |    1 -
 1 file changed, 1 deletion(-)
include/asm-cris/posix_types.h +0 -1
@@ -52,7 +52,6 @@
 } __kernel_fsid_t;
 
 #ifdef __KERNEL__
-#include <asm/bitops.h>
 
 #undef	__FD_SET
 #define __FD_SET(fd,fdsetp) set_bit(fd, (void *)(fdsetp))

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

#1 lore raw
Quoted 13 lines · On Tue, 30 Oct 2007 10:28:11 +0100 Jesper Nilsson <[email protected]>…

Remove include of asm/bitops.h, not needed here, corrects compilation error (__le64 undefined).

Signed-off-by Jesper Nilsson <[email protected]>
---
 posix_types.h |    1 -
 1 file changed, 1 deletion(-)

include/asm-cris/posix_types.h line 57

Quoted 7 lines
include/asm-cris/posix_types.h +0 -1
@@ -52,7 +52,6 @@
 } __kernel_fsid_t;
 
 #ifdef __KERNEL__
-#include <asm/bitops.h>
 
 #undef	__FD_SET
 #define __FD_SET(fd,fdsetp) set_bit(fd, (void *)(fdsetp))

This doesn't apply and I'm not sure that it is still needed or correct.

I'll drop it.

Please always prepare and test patches against the latest kernel. 2.6.23 is very much _not_ the latest kernel - there is a 50MB diff between 2.6.23 and 2.6.24-rc1. That's a lot of difference.

author
#2 lore raw
Quoted 10 lines · Andrew Morton
Quoted 2 lines · On Tue, 30 Oct 2007 10:28:11 +0100 Jesper Nilsson <[email protected]>…

Remove include of asm/bitops.h, not needed here, corrects compilation error (__le64 undefined).

[snip]

This doesn't apply and I'm not sure that it is still needed or correct.

I'll drop it.

Unfortunately it is still needed, I'll resend a fresh patch against Linus git tree.

Compile error:

CC arch/cris/kernel/asm-offsets.s
In file included from include/asm/byteorder.h:23,

                 from include/asm-generic/bitops/le.h:5,
                 from include/asm-generic/bitops/ext2-non-atomic.h:4,
                 from include/asm/bitops.h:163,
                 from include/linux/bitops.h:17,
                 from include/asm/posix_types.h:55,
                 from include/linux/posix_types.h:47,
                 from include/linux/types.h:11,
                 from include/linux/capability.h:16,
                 from include/linux/sched.h:49,
                 from arch/cris/kernel/asm-offsets.c:1:

include/linux/byteorder/little_endian.h:43: parse error before "__cpu_to_le64p" include/linux/byteorder/little_endian.h:44: warning: return type defaults to int' include/linux/byteorder/little_endian.h: In function __cpu_to_le64p':
include/linux/byteorder/little_endian.h:45: `__le64' undeclared (first use in this function)
....

Quoted 3 lines

Please always prepare and test patches against the latest kernel. 2.6.23 is very much _not_ the latest kernel - there is a 50MB diff between 2.6.23 and 2.6.24-rc1. That's a lot of difference.

I will do so from now on.

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

author
#3 lore raw
Quoted 28 lines · Jesper Nilsson
Quoted 9 lines · Andrew Morton
Quoted 2 lines · On Tue, 30 Oct 2007 10:28:11 +0100 Jesper Nilsson <[email protected]>…

Remove include of asm/bitops.h, not needed here, corrects compilation error (__le64 undefined).

[snip]

This doesn't apply and I'm not sure that it is still needed or correct.

I'll drop it.

Unfortunately it is still needed, I'll resend a fresh patch against Linus git tree.

Compile error:

CC arch/cris/kernel/asm-offsets.s
In file included from include/asm/byteorder.h:23,

                 from include/asm-generic/bitops/le.h:5,
                 from include/asm-generic/bitops/ext2-non-atomic.h:4,
                 from include/asm/bitops.h:163,
                 from include/linux/bitops.h:17,
                 from include/asm/posix_types.h:55,
                 from include/linux/posix_types.h:47,
                 from include/linux/types.h:11,
                 from include/linux/capability.h:16,
                 from include/linux/sched.h:49,
                 from arch/cris/kernel/asm-offsets.c:1:
Quoted 5 lines

include/linux/byteorder/little_endian.h:43: parse error before "__cpu_to_le64p" include/linux/byteorder/little_endian.h:44: warning: return type defaults to int' include/linux/byteorder/little_endian.h: In function __cpu_to_le64p':
include/linux/byteorder/little_endian.h:45: `__le64' undeclared (first use in this function)
....

Remove include of asm/bitops.h, not needed here, corrects compilation error (__le64 undeclared).

Signed-off-by Jesper Nilsson <[email protected]>
---
 posix_types.h |    1 -
 1 file changed, 1 deletion(-)
include/asm-cris/posix_types.h +0 -1
index 92000d0..3a5e4c4 100644
@@ -52,7 +52,6 @@ typedef struct {
 } __kernel_fsid_t;
 
 #ifdef __KERNEL__
-#include <linux/bitops.h>
 
 #undef	__FD_SET
 #define __FD_SET(fd,fdsetp) set_bit(fd, (void *)(fdsetp))

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]