Skip to contentSkip to conversation

Fix make headers_check for tipc

PATCH In review Dave Jones 3 participants 3 messages Oct 31, 2007

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

PATCH 1/1 Fix make headers_check for tipc

make headers_check currently fails in mainline with..

include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers

There's no reason to even include this in this header as far as I can tell.

Signed-off-by Dave Jones <[email protected]>
include/linux/tipc_config.h +0 -1
index b0c916d..83532ee 100644
@@ -38,7 +38,6 @@
 #define _LINUX_TIPC_CONFIG_H_
 
 #include <linux/types.h>
-#include <linux/string.h>
 #include <asm/byteorder.h>
 
 /*
Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 5 lines · Dave Jones

make headers_check currently fails in mainline with..

include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers

There's no reason to even include this in this header as far as I can tell.

The inline functions uses memcpy().

But if you just pull a fresh tree you will notice that it is fixed. Davem did so in a rather elegant way.

Sam

#2 lore raw
In reply to Dave Jones

From: Dave Jones <[email protected]>
Date: Wed, 31 Oct 2007 17:29:32 -0400

Quoted 7 lines

make headers_check currently fails in mainline with..

include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers

There's no reason to even include this in this header as far as I can tell.

Signed-off-by Dave Jones <[email protected]>

It uses memcpy() in the inline routines which are in fact used by both userspace and the kernel. The change you are suggesting will also break the TIPC kernel build.

A proper fix has been merged into Linus's tree already.