Skip to contentSkip to conversation

fixed event counters

PATCH In review Len Brown 2 participants 2 messages Nov 2, 2007

Subsystems (2)
ACPI ACPI component architecture (acpica)
lore
Share & tools
lore

Len Brown

author reviewer
#0 lore raw

PATCH 1/1 fixed event counters

Bob,
I'm planning to add the following counters to the ACPICA code in Linux.

thanks,
-Len

drivers/acpi/events/evevent.c +1 -1
index a1f87b5..8bf4dbe 100644
@@ -261,7 +261,7 @@ u32 acpi_ev_fixed_event_detect(void)
 			enable_bit_mask)) {
 
 			/* Found an active (signalled) event */
-
+			acpi_fixed_event_count[i]++;
 			int_status |= acpi_ev_fixed_event_dispatch((u32) i);
 		}
 	}
drivers/acpi/utilities/utglobal.c +2 -0
index af33358..fbb9bec 100644
@@ -673,6 +673,8 @@ void acpi_ut_init_globals(void)
 	/* GPE support */
 
 	acpi_gpe_count = 0;
+	for (i = 0; i < ACPI_NUM_FIXED_EVENTS; i++)
+		acpi_fixed_event_count[i] = 0;
 	acpi_gbl_gpe_xrupt_list_head = NULL;
 	acpi_gbl_gpe_fadt_blocks[0] = NULL;
 	acpi_gbl_gpe_fadt_blocks[1] = NULL;
include/acpi/acglobal.h +1 -0
index 24c3f05..a27ba06 100644
@@ -120,6 +120,7 @@ extern u32 acpi_gbl_nesting_level;
 /* Event counters */
 
 ACPI_EXTERN u32 acpi_gpe_count;
+ACPI_EXTERN u32 acpi_fixed_event_count[ACPI_NUM_FIXED_EVENTS];
 
 /* Support for dynamic control method tracing mechanism */
#1 lore raw

We can roll this into the base code.

Then, I would like to see a new interface to get these things, rather than have upper code poking around in ACPICA globals.

Like: AcpiGetStatistics

We could return event counts, gpe counts, total SCI count, # methods executed, etc., etc.

Bob

Review

Quoted 14 lines

-----Original Message-----
From: Len Brown [mailto:[email protected]]
Sent: Friday, November 02, 2007 10:05 AM
To: Moore, Robert
Cc: [email protected]
Subject: [ACPICA PATCH] fixed event counters

Bob,
I'm planning to add the following counters to the ACPICA code in Linux.

thanks,

(quoted diff) +0 -1
-Len
(quoted diff) +0 -0

b/drivers/acpi/events/evevent.c

drivers/acpi/events/evevent.c u32 acpi_ev_fixed_event_detect(void) · line 265

Quoted 10 lines

index a1f87b5..8bf4dbe 100644

drivers/acpi/events/evevent.c +1 -1
@@ -261,7 +261,7 @@ u32 acpi_ev_fixed_event_detect(void)
 			enable_bit_mask)) {
 
 			/* Found an active (signalled) event */
-
+			acpi_fixed_event_count[i]++;
 			int_status |= acpi_ev_fixed_event_dispatch((u32)

i);

Quoted 28 lines
drivers/acpi/events/evevent.c +0 -0
 		}
 	}
drivers/acpi/utilities/utglobal.c +2 -0
index af33358..fbb9bec 100644
@@ -673,6 +673,8 @@ void acpi_ut_init_globals(void)
 	/* GPE support */
 
 	acpi_gpe_count = 0;
+	for (i = 0; i < ACPI_NUM_FIXED_EVENTS; i++)
+		acpi_fixed_event_count[i] = 0;
 	acpi_gbl_gpe_xrupt_list_head = NULL;
 	acpi_gbl_gpe_fadt_blocks[0] = NULL;
 	acpi_gbl_gpe_fadt_blocks[1] = NULL;
include/acpi/acglobal.h +1 -0
index 24c3f05..a27ba06 100644
@@ -120,6 +120,7 @@ extern u32 acpi_gbl_nesting_level;
 /* Event counters */
 
 ACPI_EXTERN u32 acpi_gpe_count;
+ACPI_EXTERN u32 acpi_fixed_event_count[ACPI_NUM_FIXED_EVENTS];
 
 /* Support for dynamic control method tracing mechanism */