Skip to contentSkip to conversation

patch remove-broken-ptrace-special-case-code-from-file-mapping.patch queued to -stable tree

DISCUSSION Chuck Ebbert 3 participants 3 messages Nov 2, 2007 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 20 lines · Greg KH
Quoted 12 lines · Linus Torvalds
Quoted 3 lines · On Fri, 2 Nov 2007, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

Subject: Remove broken ptrace() special-case code from file mapping

Hmm. I think my patch is good, but Nick's patch is probably safer for a stable release.

Mine cleans things up, and removes a rather nasty special case entirely. But in the process, it changes user-visible behaviour (for the better, I think, but still).

Quoted 6 lines

Now, probably nobody cares about the behaviour change, but Nicks patch fixes the old broken special case instead of removing it.

Now, it might be perfectly fine to just queue this one on the assumption that nobody will really care, and doing a cleanup is better. But I wanted to point out the (small) danger.

Quoted 6 lines

I don't see Nick's patch in your tree, and I'd like to keep in sync wherever possible :)

Unless Nick really objects, and then I'll drop yours and use his, but I don't think that Duane verified that his patch fixed the issue.

I put Nick's in Fedora, so it had better work... ;)

#4 lore raw
Quoted 6 lines · Chuck Ebbert
Quoted 3 lines · Greg KH

Unless Nick really objects, and then I'll drop yours and use his, but I don't think that Duane verified that his patch fixed the issue.

I put Nick's in Fedora, so it had better work... ;)

I've tested both patches, and they both fix the problem. So no worries, either way :)

As Linus said, his patch does change the behaviour. I'm not qualified to judge how risky that is, however I think that the change is an improvement. In fact in my original bug report I suggested the old behaviour could be considered buggy and the new behaviour might be preferable.

Cheers,
Duane.

Signature · 1 line
"I never could learn to drink that blood and call it wine" - Bob Dylan
#5 lore raw
Quoted 8 lines · Duane Griffin
Quoted 6 lines · Chuck Ebbert
Quoted 3 lines · Greg KH

Unless Nick really objects, and then I'll drop yours and use his, but I don't think that Duane verified that his patch fixed the issue.

I put Nick's in Fedora, so it had better work... ;)

Quoted 8 lines

I've tested both patches, and they both fix the problem. So no worries, either way :)

As Linus said, his patch does change the behaviour. I'm not qualified to judge how risky that is, however I think that the change is an improvement. In fact in my original bug report I suggested the old behaviour could be considered buggy and the new behaviour might be preferable.

Ok, thanks for letting me know. I'll stick with Linus's patch for now, unless someone really complains :)

thanks,

greg k-h