Skip to contentSkip to conversation

kbuild: do not pick up CFLAGS from the environment

GIT PULL Sam Ravnborg 1 participant 1 message Nov 4, 2007 Kbuild

lore
Share & tools
lore
#0 lore raw

Hi Linus.

Please apply following fix.

Pull from:

ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/fix-kbuild.git

Sam

Quoted 1 line

From 69ee0b3522428a07ff1765446d631ecc7da6ae0f Mon Sep 17 00:00:00 2001

From: Sam Ravnborg <[email protected]>
Date: Sun, 4 Nov 2007 19:00:46 +0100
Subject: [PATCH] kbuild: do not pick up CFLAGS from the environment
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Too many people have CFLAGS set to support building userspace. And now Kbuild picks up CFLAGS this caused troubles.

Although people should realise that setting CFLAGS has a 'global' effect the impact on the kernel build is a suprise. So change kbuild to pick up value from KCFLAGS that is much less used.

When kbuild pick up a value it will warn like this:
Makefile:544: "WARNING: Appending $KCFLAGS (-O3) from environment to kernel $CFLAGS"

Cc Thomas Bächler <[email protected]>
Cc David Miller <[email protected]>
Cc Ingo Molnar <[email protected]>
---
 Makefile |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)
Makefile +16 -3
index 188c3b6..cb740d4 100644
@@ -528,9 +528,22 @@ KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
 KBUILD_CFLAGS += $(call cc-option,-Wno-pointer-sign,)
 
 # Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments
-KBUILD_CPPFLAGS += $(CPPFLAGS)
-KBUILD_AFLAGS   += $(AFLAGS)
-KBUILD_CFLAGS   += $(CFLAGS)
+# But warn user when we do so
+warn-assign = \
+$(warning "WARNING: Appending $$K$(1) ($(K$(1))) from $(origin K$(1)) to kernel $$$(1)")
+
+ifneq ($(KCPPFLAGS),)
+        $(call warn-assign,CPPFLAGS)
+        KBUILD_CPPFLAGS += $(KCPPFLAGS)
+endif
+ifneq ($(KAFLAGS),)
+        $(call warn-assign,AFLAGS)
+        KBUILD_AFLAGS += $(KAFLAGS)
+endif
+ifneq ($(KCFLAGS),)
+        $(call warn-assign,CFLAGS)
+        KBUILD_CFLAGS += $(KCFLAGS)
+endif
 
 # Use --build-id when available.
 LDFLAGS_BUILD_ID = $(patsubst -Wl$(comma)%,%,\
Signature · 1 line
1.5.3.4.1157.g0e74-dirty