Skip to contentSkip to conversation

ide-pmac: skip conservative PIO "downgrade"

PATCH In review Bartlomiej Zolnierkiewicz 3 participants 3 messages Nov 4, 2007 – Nov 6, 2007

Subsystems (2)
PowerPC libata
lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 2/18 ide-pmac: skip conservative PIO "downgrade"

We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.

Problem reported by Mikael.

Cc Mikael Pettersson <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/ppc/pmac.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ide/ppc/pmac.c +1 -0
Index: b/drivers/ide/ppc/pmac.c
===================================================================
@@ -1133,6 +1133,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
 	hwif->drives[0].autotune = IDE_TUNE_AUTO;
 	hwif->drives[1].autotune = IDE_TUNE_AUTO;
 	hwif->host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA |
+			   IDE_HFLAG_PIO_NO_DOWNGRADE |
 			   IDE_HFLAG_POST_SET_MODE;
 	hwif->pio_mask = ATA_PIO4;
 	hwif->set_pio_mode = pmac_ide_set_pio_mode;
Acked-by on v1 2/18
#1 lore raw
Quoted 6 lines · Bartlomiej Zolnierkiewicz

We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.

Problem reported by Mikael.

Cc Mikael Pettersson <[email protected]>
Acked-by Benjamin Herrenschmidt <[email protected]>
Quoted 17 lines
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/ppc/pmac.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/ide/ppc/pmac.c
===================================================================

drivers/ide/ppc/pmac.c +1 -0
@@ -1133,6 +1133,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
 	hwif->drives[0].autotune = IDE_TUNE_AUTO;
 	hwif->drives[1].autotune = IDE_TUNE_AUTO;
 	hwif->host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA |
+			   IDE_HFLAG_PIO_NO_DOWNGRADE |
 			   IDE_HFLAG_POST_SET_MODE;
 	hwif->pio_mask = ATA_PIO4;
 	hwif->set_pio_mode = pmac_ide_set_pio_mode;