Skip to contentSkip to conversation

ax88796: add superh to kconfig dependencies

PATCH Applied Magnus Damm 8 participants 11 messages Nov 8, 2007 – Nov 10, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

ax88796: add superh to kconfig dependencies

This patch adds sh architecture support to the ax88796 kconfig.

---

This patch was posted about a month ago but never picked up:
http://www.mail-archive.com/[email protected]/msg50018.html
The rest of the sh support is already included in rc1. Please apply.

 drivers/net/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/Kconfig +1 -1
@@ -218,7 +218,7 @@ source "drivers/net/arm/Kconfig"
 
 config AX88796
 	tristate "ASIX AX88796 NE2000 clone support"
-	depends on ARM || MIPS
+	depends on ARM || MIPS || SUPERH
 	select CRC32
 	select MII
 	help
#1 lore raw

[RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

drivers/net/Kconfig source "drivers/net/arm/Kconfig" · line 221

Quoted 4 lines · Magnus Damm

config AX88796

drivers/net/Kconfig +1 -1
 	tristate "ASIX AX88796 NE2000 clone support"
-	depends on ARM || MIPS
+	depends on ARM || MIPS || SUPERH

You know, that really sucks more and more. How about doing the following:
a) making it depend on PLAT_HAS_AX88796
b) adding selects for all subarchitectures that have the corresponding
platform device
and setting that as a uniform policy for platform drivers? For things like SM501 we would do
config MFD_SM501

	depends on PCI || PLAT_HAS_SM501

etc.

Seriously, folks, we are getting shitloads of platform drivers with no dependencies whatsoever, needed on a handful of targets and occasionally failing to build on unrelated architectures. Moreover, having a list of architectures in dependencies for each of those suckers is a PITA from the conflict POV. Not to mention platform drivers that fall into the mainline kernel with not a single platform device for them, etc.

Comments?

#9 lore raw
In reply to Magnus Damm
Quoted 11 lines · Magnus Damm

ax88796: add superh to kconfig dependencies

This patch adds sh architecture support to the ax88796 kconfig.

---

This patch was posted about a month ago but never picked up:
http://www.mail-archive.com/[email protected]/msg50018.html
The rest of the sh support is already included in rc1. Please apply.

And as per:

	http://www.mail-archive.com/[email protected]/msg50027.html
#2 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

In reply to Al Viro
Quoted 12 lines · On Thu, 8 Nov 2007 08:18:54 +0000 Al Viro <[email protected]> wrote:

drivers/net/Kconfig source "drivers/net/arm/Kconfig" · line 221

Quoted 4 lines · Magnus Damm

config AX88796

drivers/net/Kconfig +1 -1
 	tristate "ASIX AX88796 NE2000 clone support"
-	depends on ARM || MIPS
+	depends on ARM || MIPS || SUPERH

You know, that really sucks more and more. How about doing the following:
a) making it depend on PLAT_HAS_AX88796
b) adding selects for all subarchitectures that have the corresponding
platform device
and setting that as a uniform policy for platform drivers?

Yup, but we should be religious about the naming conventions. ARCH_HAS_ and PLAT_HAS_ followed by the exact name of the thus-enabled config option.

Quoted 5 lines

For things like
SM501 we would do
config MFD_SM501

	depends on PCI || PLAT_HAS_SM501

etc.

See, bug. That should be PLAT_HAS_MFD_SM501

Quoted 8 lines

Seriously, folks, we are getting shitloads of platform drivers with no dependencies whatsoever, needed on a handful of targets and occasionally failing to build on unrelated architectures. Moreover, having a list of architectures in dependencies for each of those suckers is a PITA from the conflict POV. Not to mention platform drivers that fall into the mainline kernel with not a single platform device for them, etc.

Comments?

grep PPC drivers/*/Kconfig and weep.

Applied
#10 lore raw
In reply to Magnus Damm
Quoted 5 lines · Magnus Damm

ax88796: add superh to kconfig dependencies

This patch adds sh architecture support to the ax88796 kconfig.

Quoted 8 lines

---

This patch was posted about a month ago but never picked up:
http://www.mail-archive.com/[email protected]/msg50018.html
The rest of the sh support is already included in rc1. Please apply.

 drivers/net/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

applied

#3 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

In reply to Al Viro
Quoted 16 lines · Al Viro

Review

Quoted 4 lines · Magnus Damm

config AX88796

(quoted diff) +1 -1
 	tristate "ASIX AX88796 NE2000 clone support"
-	depends on ARM || MIPS
+	depends on ARM || MIPS || SUPERH

You know, that really sucks more and more. How about doing the following:
a) making it depend on PLAT_HAS_AX88796
b) adding selects for all subarchitectures that have the corresponding
platform device
and setting that as a uniform policy for platform drivers? For things like SM501 we would do
config MFD_SM501

	depends on PCI || PLAT_HAS_SM501

etc.

Quoted 8 lines

Seriously, folks, we are getting shitloads of platform drivers with no dependencies whatsoever, needed on a handful of targets and occasionally failing to build on unrelated architectures. Moreover, having a list of architectures in dependencies for each of those suckers is a PITA from the conflict POV. Not to mention platform drivers that fall into the mainline kernel with not a single platform device for them, etc.

Comments?

commit def47c5095d53814512bb0c62ec02dfdec769db1

Author: Jeff Garzik <[email protected]>
Date:   Tue Jul 10 14:06:48 2007 -0400

[netdrvr] Fix dependencies for ax88796 ne2k clone driver

It needs writesb(), not available on all platforms.

drivers/net/Kconfig +1 -0
index a3bef22..a64c2fb 100644
@@ -199,6 +199,7 @@ source "drivers/net/arm/Kconfig"
 
 config AX88796
        tristate "ASIX AX88796 NE2000 clone support"
+       depends on ARM || MIPS
        select CRC32
        select MII
        help

If writesb() is not an official API then maybe the answer should have been to either add that API to other architectures or fix the driver.

I guess this incident means I need to go through all Kconfig* files to see what bogus architecture dependencies on MIPS or !MIPS exist ...

Ralf

#4 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

Quoted 6 lines · Ralf Baechle

If writesb() is not an official API then maybe the answer should have been to either add that API to other architectures or fix the driver.

I guess this incident means I need to go through all Kconfig* files to see what bogus architecture dependencies on MIPS or !MIPS exist ...

While writesb() isn't an official API, the iowriteX_rep() interfaces theoretically are. Tidying up the driver for iomap is probably a better option.

#5 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

Quoted 10 lines · Paul Mundt
Quoted 6 lines · Ralf Baechle

If writesb() is not an official API then maybe the answer should have been to either add that API to other architectures or fix the driver.

I guess this incident means I need to go through all Kconfig* files to see what bogus architecture dependencies on MIPS or !MIPS exist ...

While writesb() isn't an official API, the iowriteX_rep() interfaces theoretically are. Tidying up the driver for iomap is probably a better option.

writesb() predates iowriteX_rep() interfaces by quite a number of years, though if you're using writesb(), converting over to iowriteX_rep() is really a no-brainer.

writesb() is effectively what mmio_outsb() is, and exists to do what outsb() does but for peripherals mapped using ioremap on ARM rather than trying to emulate them via the legacy x86 IO interfaces.

Note that it would've been far better that whoever invented mmio_outsb() looked around and noticed that some of us already have an implementation called writesb()... but time has proven that folk seem to be blinkered to anything not x86.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#6 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

In reply to Paul Mundt
Quoted 10 lines · Paul Mundt
Quoted 6 lines · Ralf Baechle

If writesb() is not an official API then maybe the answer should have been to either add that API to other architectures or fix the driver.

I guess this incident means I need to go through all Kconfig* files to see what bogus architecture dependencies on MIPS or !MIPS exist ...

While writesb() isn't an official API, the iowriteX_rep() interfaces theoretically are. Tidying up the driver for iomap is probably a better option.

If anyone else isn't interested in doing this, and there are no objections to having it done, then I would be willing to look at moving to the iowrite interfaces.

The only other way would be to add an 8/16bit configuration to drop the use of writesb, as I belive most people connect these devices in 16bit mode.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#7 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

In reply to Al Viro
Quoted 13 lines · Al Viro

drivers/net/Kconfig source "drivers/net/arm/Kconfig" · line 221

Quoted 4 lines · Magnus Damm

config AX88796

drivers/net/Kconfig +1 -1
 	tristate "ASIX AX88796 NE2000 clone support"
-	depends on ARM || MIPS
+	depends on ARM || MIPS || SUPERH

You know, that really sucks more and more. How about doing the following:
a) making it depend on PLAT_HAS_AX88796
b) adding selects for all subarchitectures that have the corresponding
platform device
and setting that as a uniform policy for platform drivers? For things like SM501 we would do
config MFD_SM501

Quoted 2 lines
	depends on PCI || PLAT_HAS_SM501

etc.

The PLAT_HAS_xxx method is nice, and I would like it applied to other places in the kernel (see libata arugment below), and would have acked this patch if it hadn't already been applied by Jeff.

The only reservation is that this doesn't show up the posibilty of having the driver in the menuconfig, but anyone adding new board support (should) be bright enough to look through the Kconfig scripts before deciding they need to write an entirely new driver.

I would note you may want to do PLAT_HAS_NET_AX88796 as there is entirely a posibility of confusing this with the simple parallel port driver which a board may not have support for.

Quoted 6 lines

Seriously, folks, we are getting shitloads of platform drivers with no dependencies whatsoever, needed on a handful of targets and occasionally failing to build on unrelated architectures. Moreover, having a list of architectures in dependencies for each of those suckers is a PITA from the conflict POV. Not to mention platform drivers that fall into the mainline kernel with not a single platform device for them, etc.

There is a general problem with chicken-vs-egg here, how do you submit support for a machine's platform device without the platform device being there (and vice-versa) with seperate maintainers for network and machine support?

One of my colleagues has passed along comments you made about a pair of the simtec drivers (simtec-i2c and simtec-ide) which have been added, but have no current users as patches have been stalled either in submission process, or awaiting for an resolution. In the case of simtec-ide, I would like to replace it with platform-ata, but the libata maintainers seem wholy un-interested in PLAT_HAS_PLATFORM_ATA or similar.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#8 lore raw

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

Quoted 4 lines · Ben Dooks

in submission process, or awaiting for an resolution. In the case of simtec-ide, I would like to replace it with platform-ata, but the libata maintainers seem wholy un-interested in PLAT_HAS_PLATFORM_ATA or similar.

I've either missed or forgotten your patch/proposal, want to repost to linux-ide?

I want to spread libata to the far corner of the globe, and am quite interested in supporting all architectures.

Jeff