Skip to contentSkip to conversation

Remove dead code

PATCH New Cyrill Gorcunov 1 participant 1 message Nov 12, 2007 x86

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Remove dead code

Quoted 2 lines

From d1e9989b50aac63f95c6c152fdc655a95aa3ab69 Mon Sep 17 00:00:00 2001

From: Cyrill V. Gorcunov <[email protected]>
Date: Mon, 12 Nov 2007 21:02:34 +0300
Subject: [PATCH 2/2] [IA32-EMU] Remove dead code

This patch does remove useless second time checking of fsave argument in save_i387_ia32() routine. It's possible the compiler is doing the same but that is much better to remove the dead code explicitly.

---
 arch/x86/ia32/fpu32.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/ia32/fpu32.c +0 -2
index 7ab8969..d49174a 100644
@@ -174,8 +174,6 @@ int save_i387_ia32(struct task_struct *tsk,
 	if (fsave)
 		return 0;
 	err |= __put_user(tsk->thread.i387.fxsave.swd, &buf->status);
-	if (fsave)
-		return err ? -1 : 1;
 	err |= __put_user(X86_FXSR_MAGIC, &buf->magic);
 	err |= __copy_to_user(&buf->_fxsr_env[0], &tsk->thread.i387.fxsave,
 			      sizeof(struct i387_fxsave_struct));