MN10300: Add platform MTD support for the ASB2303 board
PATCH 1/2 MN10300: Add platform MTD support for the ASB2303 board
Add platform MTD support for the ASB2303 board.
---
arch/mn10300/configs/asb2303_defconfig | 5 +- arch/mn10300/unit-asb2303/Makefile | 2 - arch/mn10300/unit-asb2303/flash.c | 100 ++++++++++++++++++++++++++++++++ 3 files changed, 105 insertions(+), 2 deletions(-)
arch/mn10300/configs/asb2303_defconfig +4 -1
@@ -282,7 +282,10 @@ CONFIG_MTD_CFI_UTIL=y # Mapping drivers for chip access # # CONFIG_MTD_COMPLEX_MAPPINGS is not set -# CONFIG_MTD_PHYSMAP is not set +CONFIG_MTD_PHYSMAP=y +CONFIG_MTD_PHYSMAP_START=0x8000000 +CONFIG_MTD_PHYSMAP_LEN=0x0 +CONFIG_MTD_PHYSMAP_BANKWIDTH=2 # CONFIG_MTD_PLATRAM is not set #
arch/mn10300/unit-asb2303/Makefile +1 -1
@@ -3,4 +3,4 @@ # Makefile for the ASB2303 board # ############################################################################### -obj-y := unit-init.o smc91111.o leds.o +obj-y := unit-init.o smc91111.o flash.o leds.o
arch/mn10300/unit-asb2303/flash.c new file +100 -0
100 lines not on this page · raw message
PATCH 2/2 MN10300: Fix MTD JEDEC probe so that the ASB2303 bootprom can be detected
Fix MTD JEDEC probe so that the ASB2303 bootprom can be accessed. This is presumably required because the bootprom is normally write-protected and so the normal flash probes don't work as they require the ability to write to the flash to send it commands.
In the condition of the excluded if-statement, uaddr is 1.
---
drivers/mtd/chips/jedec_probe.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/mtd/chips/jedec_probe.c +7 -0
@@ -1868,11 +1868,18 @@ static inline __u8 finfo_uaddr(const struct amd_flash_info *finfo, int device_ty uaddr = finfo->uaddr[uaddr_idx]; +/* the MN10300 ASB2303 board doesn't detect its bootprom if this test +* is allowed to take place, presumably because the flash is +* write-protected and so cannot be commanded for the purposes of +* probing +*/ +#ifndef CONFIG_MN10300_UNIT_ASB2303 if (uaddr !=MTD_UADDR_NOT_SUPPORTED ) {/* ASSERT("The unlock addresses for non-8-bit mode are bollocks. We don't really need an array."); */ uaddr = finfo->uaddr[0 ]; } +#endif uaddr_done:return uaddr;
Re: [PATCH 2/2] MN10300: Fix MTD JEDEC probe so that the ASB2303 bootprom can be detected
Quoted 4 lines · David Howells
Fix MTD JEDEC probe so that the ASB2303 bootprom can be accessed. This is presumably required because the bootprom is normally write-protected and so the normal flash probes don't work as they require the ability to write to the flash to send it commands.
Actually, on re-checking the documentation, this particular board doesn't appear to have a write-enable for the flash, but rather an access-enable (which is obviously installed). Furthermore, the probe does seem to manage to work out that the chip is an MBM29LV800TA, so write is apparently possible.
So the problem appears to be something other than what I thought.
Without the patch, the kernel log shows:
| physmap platform flash device: 00200001 at a0000000 | physmap-flash physmap-flash.0: map_probe failed | physmap platform flash device: 02000001 at a4000000 | physmap-flash.1: Found 4 x16 devices at 0x0 in 32-bit bank | Amd/Fujitsu Extended Query Table at 0x0040 | physmap-flash.1: Swapping erase regions for broken CFI table. | number of CFI chips: 1 | cfi_cmdset_0002: Disabling erase-suspend-program due to code brokenness. | cmdlinepart partition parsing not available | Searching for RedBoot partition table in physmap-flash.1 at offset 0xfc0000 | 4 RedBoot partitions found on MTD device physmap-flash.1 | Creating 4 MTD partitions on "physmap-flash.1": | 0x00000000-0x00040000 : "RedBoot" | mtd: Giving out device 0 to RedBoot | 0x00040000-0x00fc0000 : "unallocated" | mtd: Giving out device 1 to unallocated | 0x00fc0000-0x00fff000 : "FIS directory" | mtd: partition "FIS directory" doesn't end on an erase block -- force read-only | mtd: Giving out device 2 to FIS directory | 0x00fff000-0x01000000 : "RedBoot config" | mtd: partition "RedBoot config" doesn't start on an erase block boundary -- force read-only | mtd: Giving out device 3 to RedBoot config |
With the patch, it shows:
| physmap platform flash device: 00200001 at a0000000 | CFI: Found no physmap-flash.0 device at location zero | MTD: ASB2303: uaddr=1
(Note I added a printk to display uaddr if it reached this point.)
| Found: Fujitsu MBM29LV800TA | MTD: ASB2303: uaddr=1 | physmap-flash.0: Found 1 x16 devices at 0x0 in 16-bit bank | physmap-flash.0: Found an alias at 0x100000 for the chip at 0x0 | number of JEDEC chips: 1 | cfi_cmdset_0002: Disabling erase-suspend-program due to code brokenness. | cmdlinepart partition parsing not available | Searching for RedBoot partition table in physmap-flash.0 at offset 0xf0000 | 4 RedBoot partitions found on MTD device physmap-flash.0 | Creating 4 MTD partitions on "physmap-flash.0": | 0x00000000-0x00040000 : "RedBoot" | mtd: Giving out device 0 to RedBoot | 0x00040000-0x000f0000 : "unallocated" | mtd: Giving out device 1 to unallocated | 0x000f0000-0x000ff000 : "FIS directory" | mtd: partition "FIS directory" doesn't end on an erase block -- force read-only | mtd: Giving out device 2 to FIS directory | 0x000ff000-0x00100000 : "RedBoot config" | mtd: partition "RedBoot config" doesn't start on an erase block boundary -- force read-only | mtd: Giving out device 3 to RedBoot config | physmap platform flash device: 02000001 at a4000000 | physmap-flash.1: Found 4 x16 devices at 0x0 in 32-bit bank | physmap-flash.1: Found an alias at 0x1000000 for the chip at 0x0 | Amd/Fujitsu Extended Query Table at 0x0040 | physmap-flash.1: Swapping erase regions for broken CFI table. | number of CFI chips: 1 | cfi_cmdset_0002: Disabling erase-suspend-program due to code brokenness. | cmdlinepart partition parsing not available | Searching for RedBoot partition table in physmap-flash.1 at offset 0xfc0000 | 4 RedBoot partitions found on MTD device physmap-flash.1 | Creating 4 MTD partitions on "physmap-flash.1": | 0x00000000-0x00040000 : "RedBoot" | mtd: Giving out device 4 to RedBoot | 0x00040000-0x00fc0000 : "unallocated" | mtd: Giving out device 5 to unallocated | 0x00fc0000-0x00fff000 : "FIS directory" | mtd: partition "FIS directory" doesn't end on an erase block -- force read-only | mtd: Giving out device 6 to FIS directory | 0x00fff000-0x01000000 : "RedBoot config" | mtd: partition "RedBoot config" doesn't start on an erase block boundary -- force read-only | mtd: Giving out device 7 to RedBoot config
David
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 2/2] MN10300: Fix MTD JEDEC probe so that the ASB2303 bootprom can be detected
Quoted 2 lines · Ben Dooks
Often write protect on flash chips is a seperate pin that disables the cell writing circuitry, not the nWE pin.
That may be true, but the board documentation in this particular case doesn't list any way of write-enabling the flash. I have another, different board based on the same CPU that does have a write enable for its bootprom.
David