Skip to contentSkip to conversation

dmaengine: Correct invalid assumptions in the Kconfig text

PATCH New Dan Williams 1 participant 1 message Nov 24, 2007 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: Correct invalid assumptions in the Kconfig text

From: Haavard Skinnemoen <[email protected]>

This patch corrects recently changed (and now invalid) Kconfig descriptions for the DMA engine framework:

- Non-Intel(R) hardware also has DMA engines;
- DMA is used for more than memcpy and RAID offloading.

In fact, on most platforms memcpy and RAID aren't factors, and DMA exists so that peripherals can transfer data to/from memory while the CPU does other work.

---

This corrects a 'regression' of the Kconfig text that happened during the 2.6.24 merge window. Adrian was concerned that people were needlessly turning this capability on without the requisite hardware, but the wording is indeed misleading.

 drivers/dma/Kconfig |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/dma/Kconfig +5 -3
index 6a7d25f..c46b7c2 100644
@@ -3,11 +3,13 @@
 #
 
 menuconfig DMADEVICES
-	bool "DMA Offload Engine support"
+	bool "DMA Engine support"
 	depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
 	help
-	  Intel(R) offload engines enable offloading memory copies in the
-	  network stack and RAID operations in the MD driver.
+	  DMA engines can do asynchronous data transfers without
+	  involving the host CPU.  Currently, this framework can be
+	  used to offload memory copies in the network stack and
+	  RAID operations in the MD driver.
 
 if DMADEVICES