Skip to contentSkip to conversation

fs/cifs/cifsacl.c: check-after-use

DISCUSSION Adrian Bunk 1 participant 1 message Nov 24, 2007

lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following check-after-use in fs/cifs/cifsacl.c:

<-- snip -->

...
static void parse_dacl(struct cifs_acl *pdacl, char *end_of_acl,
struct cifs_sid *pownersid, struct cifs_sid *pgrpsid, struct inode *inode)
{
...

        if (end_of_acl < (char *)pdacl + le16_to_cpu(pdacl->size)) {
...                                                  ^^^^^^^^^^^
        if (!pdacl) {

...

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed