Skip to contentSkip to conversation

hexdump: don't print bytes with bit 7 set

PATCH New Randy Dunlap 1 participant 1 message Nov 26, 2007 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hexdump: don't print bytes with bit 7 set

From: Randy Dunlap <[email protected]>

As Herbert Xu pointed out, bytes (chars) with bit 7 (0x80) set are true with isprint() but they may not be isascii() but be Unicode instead, so don't try to print them in hex dumps.

---
 lib/hexdump.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/hexdump.c +2 -1
@@ -106,7 +106,8 @@ void hex_dump_to_buffer(const void *buf,
 	while (lx < (linebuflen - 1) && lx < (ascii_column - 1))
 		linebuf[lx++] = ' ';
 	for (j = 0; (j < rowsize) && (j < len) && (lx + 2) < linebuflen; j++)
-		linebuf[lx++] = isprint(ptr[j]) ? ptr[j] : '.';
+		linebuf[lx++] = (isascii(ptr[j]) && isprint(ptr[j])) ? ptr[j]
+				: '.';
 nil:
 	linebuf[lx++] = '\0';
 }