void* arithmnetic
Hi all...
Since begin of the ages the build of the nvidia driver says things like this:
include/asm/compat.h:210: warning: pointer of type 'void *' used in arithmetic
There are several of this warnings. The code in question for this example is:
static __inline__ void __user *compat_alloc_user_space(long len)
{
struct pt_regs *regs = task_pt_regs(current);
return (void __user *)regs->rsp - len;
}As this is dealing with mem blocks, I suppose it's counting in bytes, so we could do something like:
return (void __user *)((u8*)regs->rsp - len);
so the arithmetic knows how to inc/dec for each unity...
I think the warning is correct and that void* arithmetic is undefined in C, isn't it ?
TIA
--
J.A. Magallon <jamagallon()ono!com> \ Software is like sex:
\ It's better when it's free
Mandriva Linux release 2008.1 (Cooker) for i586
Linux 2.6.23-jam01 (gcc 4.2.2 20070909 (4.2.2-0.RC.1mdv2008.0)) SMP PREEMPT 09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0
Em Thu, Nov 29, 2007 at 01:05:31AM +0100, J.A. Magallón escreveu:
Quoted 16 lines
Hi all...
Since begin of the ages the build of the nvidia driver says things like this:
include/asm/compat.h:210: warning: pointer of type 'void *' used in arithmeticThere are several of this warnings. The code in question for this example is:
static
__inline__void__user*compat_alloc_user_space(long len){ struct pt_regs *regs = task_pt_regs(current); return (void __user *)regs->rsp - len; }
Quoted 8 lines
As this is dealing with mem blocks, I suppose it's counting in bytes, so we could do something like:
return (void __user *)((u8*)regs->rsp - len);so the arithmetic knows how to inc/dec for each unity...
I think the warning is correct and that void* arithmetic is undefined in C, isn't it ?
Yes, but not in gcc, the language the kernel is written 8)
It is allowed and the size of a void is 1. -Wpointer-arith disables this.
[acme@doppio ~]$ cat voidptr.c
#include <stdio.h>
int main(int argc, char *argv[])
{
void *ptr = argv[argc - 1];
puts(ptr + 4);
return 0;
}[acme@doppio ~]$ gcc -Wall voidptr.c -o voidptr [acme@doppio ~]$ ./a Magallón
llón
[acme@doppio ~]$ gcc -Wall -Wpointer-arith voidptr.c -o voidptr voidptr.c: In function ‘main’:
voidptr.c:7: warning: pointer of type ‘void *’ used in arithmetic [acme@doppio ~]$ ./a Magallón
llón
[acme@doppio ~]$
- Arnaldo
Quoted 4 lines · J.A. Magallón
Since begin of the ages the build of the nvidia driver says things like this:
Explicitly adding -Wpointer-arith to ones own Makefile is like admitting the code might be problematic. :->
I think sizeof(void *) == 1 is taken as granted as sizeof(int) >= 4 these days. Sigh.
2007/11/29, Jan Engelhardt <[email protected]>:
Quoted 7 lines · J.A. Magallón
Quoted 4 lines
Since begin of the ages the build of the nvidia driver says things like this:
Quoted 6 lines
Explicitly adding -Wpointer-arith to ones own
Makefileis like admitting the code might be problematic. :->I think
sizeof(void *)== 1 is taken as granted as sizeof(int) >= 4 these days. Sigh.
sizeof(void *) == 4, sizeof(void)==1, :)
Quoted 6 lines
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 5 lines · Ming Lei
2007/11/29, Jan Engelhardt <[email protected]>:
Quoted 4 lines · J.A. Magallón
Quoted 3 lines
Since begin of the ages the build of the nvidia driver says things like this:
Quoted 7 lines
Quoted 6 lines
Explicitly adding -Wpointer-arith to ones own
Makefileis like admitting the code might be problematic. :->I think
sizeof(void *)== 1 is taken as granted as sizeof(int) >= 4 these days. Sigh.
sizeof(void *)== 4, sizeof(void)==1, :)
well, sizeof(void *) == sizeof(unsigned long) maybe :)
Quoted 12 lines
Quoted 6 lines
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 6 lines · Benny Halevy
Quoted 5 lines · Ming Lei
2007/11/29, Jan Engelhardt <[email protected]>:
Quoted 4 lines · J.A. Magallón
Quoted 3 lines
Since begin of the ages the build of the nvidia driver says things like this:
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines
Explicitly adding -Wpointer-arith to ones own
Makefileis like admitting the code might be problematic. :->I think
sizeof(void *)== 1 is taken as granted as sizeof(int) >= 4 these days. Sigh.
sizeof(void *)== 4, sizeof(void)==1, :)well,
sizeof(void *)== sizeof(unsigned long) maybe :)
I *heard* that on Win64 sizeof(void *) > sizeof(long). But it's off-topic here. ;-)
Quoted 11 lines · WANG Cong
Quoted 10 lines · Benny Halevy
Quoted 9 lines · Ming Lei
2007/11/29, Jan Engelhardt <[email protected]>:
Quoted 8 lines · J.A. Magallón
Quoted 3 lines
Since begin of the ages the build of the nvidia driver says things like this:
Explicitly adding -Wpointer-arith to ones own
Makefileis like admitting the code might be problematic. :->
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
I think
sizeof(void *)== 1 is taken as granted as sizeof(int) >= 4 these days. Sigh.
sizeof(void *)== 4, sizeof(void)==1, :)well,
sizeof(void *)== sizeof(unsigned long) maybe :)I *heard* that on Win64
sizeof(void *)> sizeof(long). But it's off-topic here. ;-)
Yes, Win64 is P64, to make sure it's incompatible with the rest of the world.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds