Skip to contentSkip to conversation

ARM: OMAP: Check the get_cover_state function pointer if not set

PATCH In review Kyungmin Park 2 participants 2 messages Nov 29, 2007 – Dec 1, 2007

Subsystems (2)
MMC, SD and SDIO OMAP MMC support
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Check the get_cover_state function pointer if not set

If the get_cover_state is not set, it occurs the oops.

Signed-off-by Kyungmin Park <[email protected]>

---

drivers/mmc/host/omap.c +3 -1
index cf9d31c..d7ecece 100644
@@ -238,7 +238,9 @@ static void mmc_omap_release_slot(struct mmc_omap_slot *slot)
 static inline
 int mmc_omap_cover_is_open(struct mmc_omap_slot *slot)
 {
-	return slot->pdata->get_cover_state(mmc_dev(slot->mmc), slot->id);
+	if (slot->pdata->get_cover_state)
+		return slot->pdata->get_cover_state(mmc_dev(slot->mmc), slot->id);
+	return 0;
 }
 
 static ssize_t
#1 lore raw
Quoted 9 lines · Kyungmin Park

If the get_cover_state is not set, it occurs the oops.

Signed-off-by Kyungmin Park <[email protected]>

---

drivers/mmc/host/omap.c +0 -0
index cf9d31c..d7ecece 100644

drivers/mmc/host/omap.c static void mmc_omap_release_slot(struct mmc_omap_slot *slot) · line 246

Quoted 10 lines
drivers/mmc/host/omap.c +3 -1
@@ -238,7 +238,9 @@ static void mmc_omap_release_slot(struct mmc_omap_slot *slot)
 static inline
 int mmc_omap_cover_is_open(struct mmc_omap_slot *slot)
 {
-	return slot->pdata->get_cover_state(mmc_dev(slot->mmc), slot->id);
+	if (slot->pdata->get_cover_state)
+		return slot->pdata->get_cover_state(mmc_dev(slot->mmc), slot->id);
+	return 0;
 }
 
 static ssize_t

Pushing today.

Tony