ipwireless_cs driver for 4G PC Card

 drivers/char/pcmcia/Kconfig                        |    8
 drivers/char/pcmcia/Makefile                       |    4
 drivers/char/pcmcia/ipwireless_cs_hardware.c       | 1728 +++++++++++++++++++++
 drivers/char/pcmcia/ipwireless_cs_hardware.h       |   63

 drivers/char/pcmcia/ipwireless_cs_main.c           |  479 +++++
 drivers/char/pcmcia/ipwireless_cs_main.h           |   70
 drivers/char/pcmcia/ipwireless_cs_network.c        |  496 ++++++
 drivers/char/pcmcia/ipwireless_cs_network.h        |   54
 drivers/char/pcmcia/ipwireless_cs_setup_protocol.h |  108 +
 drivers/char/pcmcia/ipwireless_cs_tty.c            |  779 +++++++++
 drivers/char/pcmcia/ipwireless_cs_tty.h            |   48
 12 files changed, 3845 insertions(+)

might it not make more sense to put all of that into a new subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's more modular and it will keep that higher-level directory from potentially getting cluttered with even more drivers. and it would let you drop the pointless "ipwireless_cs_" prefix from all of those files as well.

Quoted 6 lines

might it not make more sense to put all of that into a new subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's more modular and it will keep that higher-level directory from potentially getting cluttered with even more drivers. and it would let you drop the pointless "ipwireless_cs_" prefix from all of those files as well.

ok, will put it into ipwireless, and the _cs suffix will go away as suggested elsewhere. The filenames will then get very generic names, do you have suggestion for better names? There are many drivers in own directory and files inside have the same prefix. Maybe we can use names like ipw-hw.c, etc.

Hi,

I'm submitting driver for IPWireless PC Card, used for 4G internet connection.
The driver has been in -mm series as ipwireless_cs.git tree for some time, is actively used and there are currently no outstanding bugs.

Rewieved-by Jiri Slaby <[email protected]>

drivers/char/pcmcia/ipwireless_cs_hardware.c new file +0 -0

new file mode 100644
index 0000000..d67ce2e

drivers/char/pcmcia/ipwireless_cs_hardware.c new file +22 -0

+static struct ipw_rx_packet *pool_allocate(struct ipw_hardware *hw,
+					   struct ipw_rx_packet *packet,
+					   int minimum_free_space)
+{
+
+	if (!packet) {
+		unsigned long flags;
+
+		/*
+		 * If this is the first fragment, then we will need to fetch a
+		 * packet to put it in.
+		 */
+		spin_lock_irqsave(&hw->spinlock, flags);
+		/* If we have one in our pool, then pull it out. */
+		if (!list_empty(&hw->rx_pool)) {
+			packet = list_first_entry(&hw->rx_pool,
+					struct ipw_rx_packet, queue);
+			list_del(&packet->queue);
+			hw->rx_pool_size--;
+			spin_unlock_irqrestore(&hw->spinlock, flags);
+		} else {
+			/* Otherwise allocate a new one. */

Hi,

I'm submitting driver for IPWireless PC Card, used for 4G internet connection.
The driver has been in -mm series as ipwireless_cs.git tree for some time, is actively used and there are currently no outstanding bugs.

I'd like to let the driver pass through LKML and then let it queue for 2.6.25.

Driver is released under GPL, original authorship belongs to Symmetric co. Jiri Kosina has fixed some bugs and made it work with recent kernels, and I work on improving the code to match linux kernel standards.

When merged, please drop ipwireless_cs.git tree from -mm and include the patch instead. Patches should be sent to me and I'll push them to mainline via Jeff Garzik's driver tree, if there's no objection.

Driver lives in drivers/char/pcmcia directory, it's a serial driver. I'm not sure if this is the right place, since it's a networking driver too and therefore should be in drivers/net/pcmcia.

There will be a wiki with info for users and developers, todo etc.

Quoted 3 lines

Driver lives in drivers/char/pcmcia directory, it's a serial driver. I'm not sure if this is the right place, since it's a networking driver too and therefore should be in drivers/net/pcmcia.

If the -main- purpose of the hardware is wireless, it should go in via John Linville, wireless maintainer...

I'm submitting driver for IPWireless PC Card, used for 4G internet connection.
The driver has been in -mm series as ipwireless_cs.git tree for some time, is actively used and there are currently no outstanding bugs.

I'd like to let the driver pass through LKML and then let it queue for 2.6.25.

Driver is released under GPL, original authorship belongs to Symmetric co. Jiri Kosina has fixed some bugs and made it work with recent kernels, and I work on improving the code to match linux kernel standards.

When merged, please drop ipwireless_cs.git tree from -mm and include the patch instead. Patches should be sent to me and I'll push them to mainline via Jeff Garzik's driver tree, if there's no objection.

Driver lives in drivers/char/pcmcia directory, it's a serial driver. I'm not sure if this is the right place, since it's a networking driver too and therefore should be in drivers/net/pcmcia.

There will be a wiki with info for users and developers, todo etc.

Regards,
David Sterba

Rewieved-by Jiri Slaby <[email protected]>

Signed-off-by Ben Martel <[email protected]>

Signed-off-by Stephen Blackheath <[email protected]>

Signed-off-by David Sterba <[email protected]>

Signed-off-by Jiri Kosina <[email protected]>

---
 MAINTAINERS                                        |    8 
 drivers/char/pcmcia/Kconfig                        |    8 
 drivers/char/pcmcia/Makefile                       |    4 
 drivers/char/pcmcia/ipwireless_cs_hardware.c       | 1728 +++++++++++++++++++++
 drivers/char/pcmcia/ipwireless_cs_hardware.h       |   63 
 drivers/char/pcmcia/ipwireless_cs_main.c           |  479 +++++
 drivers/char/pcmcia/ipwireless_cs_main.h           |   70 
 drivers/char/pcmcia/ipwireless_cs_network.c        |  496 ++++++
 drivers/char/pcmcia/ipwireless_cs_network.h        |   54 
 drivers/char/pcmcia/ipwireless_cs_setup_protocol.h |  108 +
 drivers/char/pcmcia/ipwireless_cs_tty.c            |  779 +++++++++
 drivers/char/pcmcia/ipwireless_cs_tty.h            |   48 
 12 files changed, 3845 insertions(+)

can we please drop the stupid "_cs" stuff. It is an old habit to have the shortcut for "Card Services" in the driver name, but that goes back to the time when the PCMCIA subsystem and its drivers were an external package. Especially in cases where only a PCMCIA card exists, it makes no sense anymore.

Changelog:
* files moved to ipwireless/, ipwireless_cs_ stripped from filenames
* _cs stripped from driver name
* kmalloc checks
* sync irq during shutdown
* removed /proc code, converted to module params

When merged, please drop ipwireless_cs.git tree from -mm and include the patch instead.

Regards,
David Sterba

Rewieved-by Jiri Slaby <[email protected]>

Signed-off-by Ben Martel <[email protected]>

Signed-off-by Stephen Blackheath <[email protected]>

Signed-off-by David Sterba <[email protected]>

Signed-off-by Jiri Kosina <[email protected]>

---
 MAINTAINERS                                     |    8 
 drivers/char/pcmcia/Kconfig                     |    9 
 drivers/char/pcmcia/Makefile                    |    2 
 drivers/char/pcmcia/ipwireless/Makefile         |   10 
 drivers/char/pcmcia/ipwireless/hardware.c       | 1784 ++++++++++++++++++++++++
 drivers/char/pcmcia/ipwireless/hardware.h       |   63 
 drivers/char/pcmcia/ipwireless/main.c           |  496 ++++++
 drivers/char/pcmcia/ipwireless/main.h           |   70 
 drivers/char/pcmcia/ipwireless/network.c        |  513 ++++++
 drivers/char/pcmcia/ipwireless/network.h        |   54 
 drivers/char/pcmcia/ipwireless/setup_protocol.h |  108 +
 drivers/char/pcmcia/ipwireless/tty.c            |  687 +++++++++
 drivers/char/pcmcia/ipwireless/tty.h            |   48 
 13 files changed, 3852 insertions(+)

[ CC list trimmed ]

Quoted 19 lines

Changelog:
* files moved to ipwireless/, ipwireless_cs_ stripped from filenames
* _cs stripped from driver name
* kmalloc checks
* sync irq during shutdown
* removed /proc code, converted to module params

When merged, please drop ipwireless_cs.git tree from -mm and include the patch instead.

Regards,
David Sterba

Rewieved-by Jiri Slaby <[email protected]>

Signed-off-by Ben Martel <[email protected]>

Signed-off-by Stephen Blackheath <[email protected]>

Signed-off-by David Sterba <[email protected]>

Signed-off-by Jiri Kosina <[email protected]>

Quoted 15 lines

---
 MAINTAINERS                                     |    8 
 drivers/char/pcmcia/Kconfig                     |    9 
 drivers/char/pcmcia/Makefile                    |    2 
 drivers/char/pcmcia/ipwireless/Makefile         |   10 
 drivers/char/pcmcia/ipwireless/hardware.c       | 1784 ++++++++++++++++++++++++
 drivers/char/pcmcia/ipwireless/hardware.h       |   63 
 drivers/char/pcmcia/ipwireless/main.c           |  496 ++++++
 drivers/char/pcmcia/ipwireless/main.h           |   70 
 drivers/char/pcmcia/ipwireless/network.c        |  513 ++++++
 drivers/char/pcmcia/ipwireless/network.h        |   54 
 drivers/char/pcmcia/ipwireless/setup_protocol.h |  108 +
 drivers/char/pcmcia/ipwireless/tty.c            |  687 +++++++++
 drivers/char/pcmcia/ipwireless/tty.h            |   48 
 13 files changed, 3852 insertions(+)

Andrew, what is your position on merging this into your 2.6.25 queue please? David has fixed all the issues that came up during review, so it seems to be that it's time for the driver to be merged during the upcoming merge window.

If you take it, I am perfectly fine with you dropping the ipwireless_cs git tree from -mm lineup.

Quoted 5 lines

Andrew, what is your position on merging this into your 2.6.25 queue please? David has fixed all the issues that came up during review, so it seems to be that it's time for the driver to be merged during the upcoming merge window. If you take it, I am perfectly fine with you dropping the ipwireless_cs git tree from -mm lineup.

I'd have thought that you'd merge it into git-ipwireless_cs.patch and that you would then take care of merging it into mainline at an appropriate time?

Quoted 5 lines · Andrew Morton

Quoted 5 lines

Andrew, what is your position on merging this into your 2.6.25 queue please? David has fixed all the issues that came up during review, so it seems to be that it's time for the driver to be merged during the upcoming merge window. If you take it, I am perfectly fine with you dropping the ipwireless_cs git tree from -mm lineup.

Quoted 3 lines

I'd have thought that you'd merge it into git-ipwireless_cs.patch and that you would then take care of merging it into mainline at an appropriate time?

I'd normally send this through PCMCIA maintainer's tree, but as long as there is no such thing, I thought that merging through you is the best thing to do. I don't want to bother Linus with pull request for a single new driver.