Skip to contentSkip to conversation

ARM: OMAP: Remove redundant gpio request at apollon

PATCH In review Kyungmin Park 2 participants 2 messages Dec 6, 2007 – Dec 17, 2007

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Remove redundant gpio request at apollon

The gpio request is done by gpio-keys

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-omap2/board-apollon-keys.c +0 -12
index 6b2e551..b6fa4ea 100644
@@ -77,29 +77,17 @@ static void __init apollon_sw_init(void)
 {
 	/* Enter SW - Y11 */
 	omap_cfg_reg(Y11_242X_GPIO16);
-	omap_request_gpio(SW_ENTER_GPIO16);
-	omap_set_gpio_direction(SW_ENTER_GPIO16, 1);
 	/* Up SW - AA12 */
 	omap_cfg_reg(AA12_242X_GPIO17);
-	omap_request_gpio(SW_UP_GPIO17);
-	omap_set_gpio_direction(SW_UP_GPIO17, 1);
 	/* Down SW - AA8 */
 	omap_cfg_reg(AA8_242X_GPIO58);
-	omap_request_gpio(SW_DOWN_GPIO58);
-	omap_set_gpio_direction(SW_DOWN_GPIO58, 1);
 #ifdef CONFIG_MACH_OMAP_APOLLON_PLUS
 	/* Left SW - P18 */
 	omap_cfg_reg(P18_24XX_GPIO95);
-	omap_request_gpio(SW_LEFT_GPIO95);
-	omap_set_gpio_direction(SW_LEFT_GPIO95, 1);
 	/* Right SW - M18 */
 	omap_cfg_reg(M18_24XX_GPIO96);
-	omap_request_gpio(SW_RIGHT_GPIO96);
-	omap_set_gpio_direction(SW_RIGHT_GPIO96, 1);
 	/* Esc SW - L14 */
 	omap_cfg_reg(L14_24XX_GPIO97);
-	omap_request_gpio(SW_ESC_GPIO97);
-	omap_set_gpio_direction(SW_ESC_GPIO97, 1);
 #endif
 }
maintainer
#1 lore raw
Quoted 28 lines · Kyungmin Park

The gpio request is done by gpio-keys

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-omap2/board-apollon-keys.c +0 -8
index 6b2e551..b6fa4ea 100644
@@ -77,29 +77,17 @@ static void __init apollon_sw_init(void)
 {
 	/* Enter SW - Y11 */
 	omap_cfg_reg(Y11_242X_GPIO16);
-	omap_request_gpio(SW_ENTER_GPIO16);
-	omap_set_gpio_direction(SW_ENTER_GPIO16, 1);
 	/* Up SW - AA12 */
 	omap_cfg_reg(AA12_242X_GPIO17);
-	omap_request_gpio(SW_UP_GPIO17);
-	omap_set_gpio_direction(SW_UP_GPIO17, 1);
 	/* Down SW - AA8 */
 	omap_cfg_reg(AA8_242X_GPIO58);
-	omap_request_gpio(SW_DOWN_GPIO58);
-	omap_set_gpio_direction(SW_DOWN_GPIO58, 1);
 #ifdef CONFIG_MACH_OMAP_APOLLON_PLUS
 	/* Left SW - P18 */
 	omap_cfg_reg(P18_24XX_GPIO95);
-	omap_request_gpio(SW_LEFT_GPIO95);
-	omap_set_gpio_direction(SW_LEFT_GPIO95, 1);
 	/* Right SW - M18 */

arch/arm/mach-omap2/board-apollon-keys.c static void __init apollon_sw_init(void) · line 93

Quoted 10 lines
arch/arm/mach-omap2/board-apollon-keys.c +0 -4
 	omap_cfg_reg(M18_24XX_GPIO96);
-	omap_request_gpio(SW_RIGHT_GPIO96);
-	omap_set_gpio_direction(SW_RIGHT_GPIO96, 1);
 	/* Esc SW - L14 */
 	omap_cfg_reg(L14_24XX_GPIO97);
-	omap_request_gpio(SW_ESC_GPIO97);
-	omap_set_gpio_direction(SW_ESC_GPIO97, 1);
 #endif
 }

Pushing today.

Tony