Skip to contentSkip to conversation

sound/core.h: include sound/driver.h

PATCH In review Marcin Ślusarz 2 participants 5 messages Dec 8, 2007 – Dec 19, 2007 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound/core.h: include sound/driver.h

sound/core.h: include sound/driver.h

include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h)

---
 include/sound/core.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/sound/core.h +1 -0
index 6954836..3b0903a 100644
@@ -27,6 +27,7 @@
 #include <linux/rwsem.h>		/* struct rw_semaphore */
 #include <linux/pm.h>			/* pm_message_t */
 #include <linux/device.h>
+#include <sound/driver.h>
 
 /* forward declarations */
 #ifdef CONFIG_PCI
#1 lore raw

At Sat, 8 Dec 2007 21:50:45 +0100,

Quoted 7 lines · Marcin Ślusarz

sound/core.h: include sound/driver.h

include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h)

Right now I have another (bigger) change for this include path, so this patch won't be needed any more.

I applied the patches to sound/* except for this one and
sound/memory.c. Thanks!

Takashi

Quoted 22 lines
---
 include/sound/core.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/sound/core.h +1 -1
index 6954836..3b0903a 100644
@@ -27,6 +27,7 @@
 #include <linux/rwsem.h>		/* struct rw_semaphore */
 #include <linux/pm.h>			/* pm_message_t */
 #include <linux/device.h>
+#include <sound/driver.h>
 
 /* forward declarations */
 #ifdef CONFIG_PCI
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 8 lines · Takashi Iwai

At Sat, 8 Dec 2007 21:50:45 +0100,

Quoted 6 lines · Marcin Ślusarz

sound/core.h: include sound/driver.h

include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h)

Quoted 8 lines
Quoted 1 line

Right now I have another (bigger) change for this include path, so this patch won't be needed any more.

I applied the patches to sound/* except for this one and
sound/memory.c. Thanks!

Is there anything wrong with patch for rawmidi [1]?

Marcin

[1] http://lkml.org/lkml/2007/12/8/164

#3 lore raw

At Sun, 16 Dec 2007 02:58:31 +0100,

Quoted 12 lines · Marcin Slusarz
Quoted 10 lines · Takashi Iwai

At Sat, 8 Dec 2007 21:50:45 +0100,

Quoted 7 lines · Marcin Ślusarz

sound/core.h: include sound/driver.h

include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h)

Quoted 7 lines
Quoted 6 lines

Right now I have another (bigger) change for this include path, so this patch won't be needed any more.

I applied the patches to sound/* except for this one and
sound/memory.c. Thanks!

Is there anything wrong with patch for rawmidi [1]?

Ah, sorry, forgot to mention it.

I'm still considering whether it's the best way. The changes look exaggerated just for fixing sparse warnings.

Takashi

Quoted 5 lines

Marcin

[1] http://lkml.org/lkml/2007/12/8/164

#4 lore raw
Quoted 20 lines · Takashi Iwai

At Sun, 16 Dec 2007 02:58:31 +0100,

Quoted 18 lines · Marcin Slusarz
Quoted 16 lines · Takashi Iwai

At Sat, 8 Dec 2007 21:50:45 +0100,

Quoted 7 lines · Marcin Ślusarz

sound/core.h: include sound/driver.h

include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h)

Right now I have another (bigger) change for this include path, so this patch won't be needed any more.

I applied the patches to sound/* except for this one and
sound/memory.c. Thanks!

Quoted 6 lines
Quoted 1 line

Is there anything wrong with patch for rawmidi [1]?

Ah, sorry, forgot to mention it.

I'm still considering whether it's the best way. The changes look exaggerated just for fixing sparse warnings.

It think it will let future code inspections a bit easier. But if you have a better idea how to fix it, let me know.

Marcin