Skip to contentSkip to conversation

Remove .git/branches from the .git template.

PATCH In review Kristian Høgsberg 2 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove .git/branches from the .git template.

The code in git to read the info in .git/branches is still there, but nothing ever writes to this, so lets stop creating it.

---

As far as I can see this should be safe, but I admit to never really knowing what .git/branches was originally used for - tracking remote branches or something? In any case, we only ever read from this dir so the only left in git to deal with this seems to be for compatibilty with older repos.

Kristian

 templates/branches-- |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
 delete mode 100644 templates/branches--
templates/branches-- deleted +0 -1
deleted file mode 100644
index fae8870..0000000
@@ -1 +0,0 @@
-: this is just to ensure the directory exists.
Signature · 1 line
1.5.3.4
#1 lore raw
Quoted 11 lines · Kristian Høgsberg

The code in git to read the info in .git/branches is still there, but nothing ever writes to this, so lets stop creating it.

---

As far as I can see this should be safe, but I admit to never really knowing what .git/branches was originally used for - tracking remote branches or something? In any case, we only ever read from this dir so the only left in git to deal with this seems to be for compatibilty with older repos.

This was done purely so that Cogito would not barf on a repository initialized with "git init" even if it did not bother creating necessary leading directories when it writes its rough equivalent to .git/remotes/ information. I do not recall if Cogito had such a problem anymore, but I think it can safely go when Cogito is effectively dead.

#2 lore raw
Quoted 14 lines · Junio C Hamano
Quoted 11 lines · Kristian Høgsberg

The code in git to read the info in .git/branches is still there, but nothing ever writes to this, so lets stop creating it.

---

As far as I can see this should be safe, but I admit to never really knowing what .git/branches was originally used for - tracking remote branches or something? In any case, we only ever read from this dir so the only left in git to deal with this seems to be for compatibilty with older repos.

Quoted 5 lines

This was done purely so that Cogito would not barf on a repository initialized with "git init" even if it did not bother creating necessary leading directories when it writes its rough equivalent to .git/remotes/ information. I do not recall if Cogito had such a problem anymore, but I think it can safely go when Cogito is effectively dead.

OK, I don't know where cogito is in that respect, I thought maybe we had just forgotten we still created that directory. Should we just try to apply the patch to find out how it might interact with cogito?

Kristian