alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value.

PATCH In review Miguel Botón 2 participants 2 messages Dec 16, 2007 – Dec 17, 2007 Sound

Share & tools

Miguel Botón

author

2007-12-16 00:36 UTC #0 lore raw

PATCH 1/1 alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value.

"[ALSA] Use posix clock monotonic for PCM and timer timestamps" introduces a bug that makes audio device unusable in some computers.

Signed-off-by Miguel Botón <[email protected]>

include/sound/asound.h +1 -1

index 475eb71..d35aa44 100644
@@ -443,7 +443,7 @@ enum {
 enum {
 	SNDRV_PCM_IOCTL_PVERSION = _IOR('A', 0x00, int),
 	SNDRV_PCM_IOCTL_INFO = _IOR('A', 0x01, struct snd_pcm_info),
-	SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x03, int),
+	SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x02, int),
 	SNDRV_PCM_IOCTL_HW_REFINE = _IOWR('A', 0x10, struct snd_pcm_hw_params),
 	SNDRV_PCM_IOCTL_HW_PARAMS = _IOWR('A', 0x11, struct snd_pcm_hw_params),
 	SNDRV_PCM_IOCTL_HW_FREE = _IO('A', 0x12),

Signature · 1 line

	Miguel Botón

Jaroslav Kysela

maintainer

2007-12-17 08:08 UTC #1 lore raw

Quoted 4 lines · Miguel Botón

"[ALSA] Use posix clock monotonic for PCM and timer timestamps" introduces a bug that makes audio device unusable in some computers.
Signed-off-by Miguel Botón <[email protected]>

Thanks for notify that old alsa-lib binaries have trouble with this patch. But your fix is wrong. New and old ioctls are incompatible. I added old ioctl back to our HG tree.

Jaroslav

Quoted 17 lines

include/sound/asound.h +1 -1

index 475eb71..d35aa44 100644
@@ -443,7 +443,7 @@ enum {
 enum {
 	SNDRV_PCM_IOCTL_PVERSION = _IOR('A', 0x00, int),
 	SNDRV_PCM_IOCTL_INFO = _IOR('A', 0x01, struct snd_pcm_info),
-	SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x03, int),
+	SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x02, int),
 	SNDRV_PCM_IOCTL_HW_REFINE = _IOWR('A', 0x10, struct snd_pcm_hw_params),
 	SNDRV_PCM_IOCTL_HW_PARAMS = _IOWR('A', 0x11, struct snd_pcm_hw_params),
 	SNDRV_PCM_IOCTL_HW_FREE = _IO('A', 0x12),

Signature · 2 lines

-- 
	Miguel Botón

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project