Skip to contentSkip to conversation

kconfig: Obey KCONFIG_ALLCONFIG choices with randconfig.

PATCH Paul Mundt 1 participant 1 message Dec 17, 2007 Kconfig

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

Currently when using KCONFIG_ALLCONFIG with randconfig the choice options are clobbered. As recommended by Roman, this adds an is_new test to see whether to select a new option or obey the existing one.

This is a resend of the earlier patch a couple of weeks ago, since there was no reply. Original thread is at http://lkml.org/lkml/2007/11/28/94

It would be nice to have this for 2.6.24.

---

 scripts/kconfig/conf.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/conf.c +2 -1
index a38787a..8d6f174 100644
@@ -374,7 +374,8 @@ static int conf_choice(struct menu *menu)
 				continue;
 			break;
 		case set_random:
-			def = (random() % cnt) + 1;
+			if (is_new)
+				def = (random() % cnt) + 1;
 		case set_default:
 		case set_yes:
 		case set_mod: