ARM: S3C24x0 SoC NAND controller support
PATCH 1/1 ARM: S3C24x0 SoC NAND controller support
This patch adds NAND support to the S3C24x0 SoC code in u-boot
cpu/arm920t/s3c24x0/Makefile +1 -1
@@ -26,7 +26,7 @@ LIB = $(obj)lib$(SOC).a COBJS = i2c.o interrupts.o serial.o speed.o \ - usb.o usb_ohci.o + usb.o usb_ohci.o nand.o SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS))
cpu/arm920t/s3c24x0/nand.c new file +179 -0
179 lines not on this page · raw message
Signature · 3 lines
- Harald Welte <[email protected]> http://openmoko.org/ ============================================================================ Software for the world's first truly open Free Software mobile phone
Wolfgang Denk
AppliedPATCH 1/1 ARM: S3C24x0 SoC NAND controller support
Quoted 3 lines · In message <[email protected]> you wrote:
This patch adds NAND support to the S3C24x0 SoC code in u-boot
Signed-off-by Harald Welte <[email protected]>
Applied, thanks - but ...
cpu/arm920t/s3c24x0/Makefile line 29
Quoted 10 lines
Index: u-boot/cpu/arm920t/s3c24x0/Makefile
===================================================================cpu/arm920t/s3c24x0/Makefile +1
-1@@ -26,7 +26,7 @@ LIB = $(obj)lib$(SOC).a COBJS = i2c.o interrupts.o serial.o speed.o \ - usb.o usb_ohci.o + usb.o usb_ohci.o nand.o
Please keep lists of names sorted, and mind the coding style:
...
warning: 1 line applied after fixing whitespace errors.
...
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Real computer scientists don't comment their code. The identifiers are so long they can't afford the disk space.
PATCH 1/1 ARM: S3C24x0 SoC NAND controller support
Quoted 11 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:
This patch adds NAND support to the S3C24x0 SoC code in u-boot
Signed-off-by Harald Welte <[email protected]>Applied, thanks - but ...
cpu/arm920t/s3c24x0/Makefile line 29
Quoted 2 lines
cpu/arm920t/s3c24x0/Makefile +1
-1- usb.o usb_ohci.o + usb.o usb_ohci.o nand.oPlease keep lists of names sorted, and mind the coding style:
Thanks a lot, will try to improve in the next round.
Signature · 3 lines
- Harald Welte <[email protected]> http://openmoko.org/ ============================================================================ Software for the world's first truly open Free Software mobile phone